Repository navigation
CI: collect coverage only in the job that uploads it - #598
Merged
Merged
Conversation
Only the ubuntu / Python 3.14 job uploads coverage to Codecov. Collecting it in the other jobs only slows them down, in particular on Python < 3.14: with `branch = True`, coverage.py can't use its `sys.monitoring`-based core there and falls back to the slower C tracer. E.g., pytest took 225 s on ubuntu / 3.12 vs 102 s on 3.14. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #598 +/- ##
=======================================
Coverage 79.71% 79.71%
=======================================
Files 70 70
Lines 8315 8315
Branches 1506 1506
=======================================
Hits 6628 6628
Misses 1198 1198
Partials 489 489 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only the ubuntu / Python 3.14 job uploads coverage to Codecov, but all jobs ran the tests with
--cov. That slows down the other jobs considerably on Python < 3.14: withbranch = True(.coveragerc), coverage.py can't use itssys.monitoring-based core there and falls back to the slower C tracer. E.g., pytest took 225 s on ubuntu / 3.12 vs. 102 s on 3.14; locally,test_add_noiseon 3.12 took 33 s without and 127 s with coverage.Now,
--covis only passed in the job that uploads the report. The Codecov report is unaffected.🤖 Generated with Claude Code