Repository navigation
v2 lint: warn about unused placeholders - #599
Merged
Merged
Conversation
dweindl
force-pushed
the
v2_lint_unused_placeholders
branch
from
November 16, 2026 20:54
ece6e56 to
bf53e2c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #599 +/- ##
==========================================
+ Coverage 79.75% 79.78% +0.02%
==========================================
Files 70 70
Lines 8332 8354 +22
Branches 1510 1515 +5
==========================================
+ Hits 6645 6665 +20
- Misses 1197 1198 +1
- Partials 490 491 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dweindl
force-pushed
the
v2_lint_unused_placeholders
branch
from
November 17, 2026 07:35
bf53e2c to
094d3e3
Compare
dweindl
marked this pull request as ready for review
November 17, 2026 07:42
dweindl
force-pushed
the
v2_lint_unused_placeholders
branch
from
November 17, 2026 07:53
094d3e3 to
0ba8e38
Compare
dilpath
approved these changes
Nov 17, 2026
Add `CheckUnusedPlaceholders` to the default validation tasks. It warns about entries of `observablePlaceholders` that are used in neither `observableFormula` nor `noiseFormula`, and about entries of `noisePlaceholders` that are not used in `noiseFormula`. Closes PEtab-dev#587. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl
force-pushed
the
v2_lint_unused_placeholders
branch
from
November 17, 2026 13:47
0ba8e38 to
0cd6659
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
CheckUnusedPlaceholdersto the default v2 validation tasks. It emits a warning forobservablePlaceholdersthat are used in neitherobservableFormulanornoiseFormula(observable placeholders are allowed in the noise formula),noisePlaceholdersthat are not used innoiseFormula.The spec allows declaring placeholders that are not used, so this is a warning, not an error. Usage is determined from the sympified formulas, so a placeholder that cancels out (e.g.
x + p - p) is reported as unused.Closes #587.
🤖 Generated with Claude Code