Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #601 +/- ##
==========================================
+ Coverage 79.93% 80.13% +0.20%
==========================================
Files 70 70
Lines 8362 8429 +67
Branches 1519 1544 +25
==========================================
+ Hits 6684 6755 +71
+ Misses 1188 1183 -5
- Partials 490 491 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dweindl
force-pushed
the
worktree-565
branch
from
November 17, 2026 14:33
edc036b to
f73091a
Compare
PEtab 2.0.0 erratum E1 allows `lowerBound=-inf` and `upperBound=inf`. If any estimated parameter has a prior, estimated parameters with infinite bounds require an explicit proper prior, since the default `uniform(lowerBound, upperBound)` prior would be improper. * `Parameter.lb` must be finite or `-inf`, `Parameter.ub` finite or `inf`. Errors refer to the `lowerBound`/`upperBound` columns. * `CheckPriorDistribution` reports estimated parameters with infinite bounds and no prior if the problem has a MAP objective. * `Problem.get_startpoint_distributions` raises a `ValueError` naming estimated parameters with infinite or missing bounds and no prior, instead of returning improper uniform distributions. `get_priors` delegates to it for MAP problems. * `Problem.sample_parameter_startpoints` used `get_priors`, which is empty for maximum likelihood problems, and thus failed. It now uses `get_startpoint_distributions`, returns an `(n_starts, 0)` array if no parameters are estimated, and no longer accepts and ignores arbitrary keyword arguments. * Test that prior truncation at bounds matching the prior's domain is a no-op, and that one-sided infinite bounds still truncate. Closes PEtab-dev#565. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl
force-pushed
the
worktree-565
branch
from
November 17, 2026 16:11
f73091a to
799768f
Compare
dweindl
marked this pull request as ready for review
November 17, 2026 16:16
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements PEtab 2.0.0 erratum E1:
lowerBoundmay be-inf,upperBoundmay beinf, and if any estimated parameter has a prior, estimated parameters with infinite bounds need an explicit proper prior.Parameter.lbmust be finite or-inf,Parameter.ubfinite orinf. Previously, e.g.lb=ub=infwas accepted.CheckPriorDistributionreports estimated parameters with infinite bounds and no prior if the problem has a MAP objective. Explicit improperuniform/log-uniformpriors (e.g., with infinite prior parameters) are already rejected via Reject improperUniformandLogUniformdistributions #604.Problem.get_priorsandProblem.get_startpoint_distributionsraise aValueErrornaming the parameters with infinite (or missing) bounds and no prior, instead of the generic error fromUniform(since Reject improperUniformandLogUniformdistributions #604) or, before that, an improperUniformthat failed on sampling. I chose this over adding a fallback-distribution argument to keep the API unchanged; a fallback could be added later if needed.Problem.sample_parameter_startpointsusedget_priors, which is empty for maximum likelihood problems, and thus always failed for them. It now usesget_startpoint_distributions(identical toget_priorsfor MAP problems). It also returns an(n_starts, 0)array if no parameters are estimated, and no longer accepts arbitrary keyword arguments. These were a leftover from copying the v1 method, where they are forwarded topetab.v1.sampling.sample_parameter_startpoints; in v2 they have been silently ignored since v2: Startpoint sampling #380, so nothing should depend on them.log-normalon[0, inf]) is a no-op, and that one-sided infinite bounds still truncate at the finite bound.Infinite nominal values (erratum E3) were already accepted; no change.
Closes #565.
🤖 Generated with Claude Code