Repository navigation
Treat trunc=[-inf, inf] as no truncation in distributions - #603
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #603 +/- ##
==========================================
+ Coverage 79.75% 79.84% +0.08%
==========================================
Files 70 70
Lines 8332 8334 +2
Branches 1510 1511 +1
==========================================
+ Hits 6645 6654 +9
+ Misses 1197 1190 -7
Partials 490 490 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dweindl
marked this pull request as ready for review
November 17, 2026 08:23
dilpath
approved these changes
Nov 17, 2026
`Distribution.__init__` only recognized the tuple `(-inf, inf)` as "no truncation", but `petab.v2.Parameter.prior_dist` passes the bounds as a list. Such distributions were therefore handled as truncated, e.g., sampled via the inverse CDF instead of directly. Convert `trunc` to a tuple before the comparison, so any sequence is accepted and stored consistently. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl
force-pushed
the
distributions_trunc_list
branch
from
November 17, 2026 13:49
900947d to
a940716
Compare
dweindl
enabled auto-merge
November 17, 2026 13:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Distribution.__init__only recognized the tuple(-inf, inf)as "no truncation", butpetab.v2.Parameter.prior_distpasses the bounds as a list. Such distributions were therefore handled as truncated, e.g., sampled via the inverse CDF instead of directly. Results were still correct.truncis now converted to a tuple before the comparison, so any sequence is accepted and stored consistently.🤖 Generated with Claude Code