Repository navigation
Conversation
dweindl
force-pushed
the
v2_unique_ids
branch
from
November 17, 2026 10:27
a58047c to
0b4778b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #606 +/- ##
==========================================
+ Coverage 80.03% 80.19% +0.16%
==========================================
Files 70 70
Lines 8419 8498 +79
Branches 1541 1560 +19
==========================================
+ Hits 6738 6815 +77
- Misses 1189 1194 +5
+ Partials 492 489 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dweindl
force-pushed
the
v2_unique_ids
branch
2 times, most recently
from
November 17, 2026 11:27
ae6230c to
b60d6aa
Compare
Add `CheckGloballyUniqueIds`. Condition, experiment, observable, model and placeholder IDs, mapping table `petabEntityId`s and parameter IDs must be defined only once and must not be model entity IDs. Parameter table entries for model entities or mapped entities are references, not definitions. The task replaces `CheckObservablesDoNotShadowModelEntities` in the default validation tasks, which is deprecated, and the overlapping checks in `CheckMappingTable`. Closes PEtab-dev#555. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`CheckGloballyUniqueIds` now runs on the full problem of multi-model problems. Table entries are compared across all models. IDs from the condition, experiment, observable and parameter tables only clash with the entities of the models they are used with; mapping table IDs, model IDs and unused IDs are compared with all models. Each clash is reported once. Annotation-only mapping table rows must not refer to model entities. Add `CheckPlaceholdersOnlyUsedInOwnObservable`: placeholders must not be used in other observables, the condition table or measurement overrides, and noise placeholders must not be used in the observable formula. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl
force-pushed
the
v2_unique_ids
branch
from
November 17, 2026 14:36
b60d6aa to
aacc56d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
CheckGloballyUniqueIdsto the default v2 validation tasks. It reports IDs that are defined more than once or coincide with a model entity, together with the places where they are defined, e.g.`a` (observable placeholder of `o1`, observable placeholder of `o2`).Definitions are condition, experiment, observable, model and placeholder IDs, mapping table
petabEntityIds (except identity and annotation-only rows), and parameter table IDs that aren't mapped entities. A parameter table entry for a model entity refers to that entity and is no clash. Annotation-only mapping table rows must not refer to model entities, since such rows are for entities that are not in any model. Duplicates within a single table are still reported byCheckUniquePrimaryKeys.Adds
CheckPlaceholdersOnlyUsedInOwnObservable: placeholders must not be used in other observables, condition targets or target values, or measurement overrides, and noise placeholders must not be used in the observable formula.The new tasks replace
CheckObservablesDoNotShadowModelEntities(now deprecated) in the default validation tasks, and the checks inCheckMappingTableforpetabEntityIds that are defined elsewhere or referenced in the model.For multi-model problems, both tasks run on the full problem, so table entries are compared across all models. IDs from the condition, experiment, observable and parameter tables only clash with the entities of the models they are used with (based on
Problem.split_by_model). Mapping table IDs, model IDs and IDs not used with any model are compared with the entities of all models.Neither the benchmark collection (converted with
petab1to2) nor the PEtab v2 test suite has such clashes.Closes #555.
🤖 Generated with Claude Code