Repository navigation
Add earnings cap to NDC and DB systems - #1282
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1282 +/- ##
==========================================
+ Coverage 79.68% 79.81% +0.13%
==========================================
Files 24 24
Lines 6762 6811 +49
==========================================
+ Hits 5388 5436 +48
- Misses 1374 1375 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
Author
|
All local tests passing: |
jdebacker
marked this pull request as ready for review
November 16, 2026 13:19
rickecon
approved these changes
Nov 16, 2026
Member
|
@jdebacker. This looks good. Will merge as soon as tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PR #1273, they hybrid DB/NDC system was added to the pension regimes modeled in OG-Core. This regime has two thresholds: one to determine the earnings above which contributions went to the NDC system (
factor1_db_ndc_hybrid) and another to determine the maximum earnings from which contributions to the NDC system would be made (factor2_db_ndc_hybrid).This PR modified the DB and NDC functions so that thresholds can be set determining the range or earnings that are contributed to these systems (without having the hybrid DB/NDC system).