Skip to content

Funded defined contribution pillar, part 2: steady state - #1284

Open
jdebacker wants to merge 4 commits into
PSLmodels:masterfrom
jdebacker:FDC_SS
Open

jdebacker wants to merge 4 commits into
PSLmodels:masterfrom
jdebacker:FDC_SS

Conversation

@jdebacker

@jdebacker jdebacker commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

This PR is stacked on #1283 (FDC part 1), so its first commit is #1283's. Review only the second commit, "Solve the steady state with the funded defined contribution pillar", until #1283 merges.

This is part 2 of 4 for the funded defined contribution (FDC) pillar: the steady state. With fdc_tau = 0 (the default) every result is unchanged: the off path adds 0.0 to the existing terms, and the small-model steady state matches part 1 exactly.

What changes when fdc_tau > 0

  • Household budget. Consumption is reduced by the contribution and increased by the annuity, through household.fdc_net_flow. These flows stay out of tax.net_taxes, so they are neither government revenue nor outlays, and the tax outputs are unaffected.

  • Labor FOC. household.fdc_labor_wedge adds two terms:

    • the direct cost of the contribution, −u′(c_s)/p̃ · ∂C_s/∂n_s;
    • the value of the annuity it buys, discounted with the household's own utility weights β^{u−s} Π(1−ρ) e^{(1−σ) g_y (u−s)}.

    Contributions are therefore not treated as a pure tax.

  • Capital market. Fund assets F (aggregates.get_F) are aggregated like get_B, in next-period detrended units like b_{s+1}. They add to domestic savings: get_K_splits(B + F, …).

  • Bequests. Balances of members who die before retirement are bequeathed (added to get_BQ). After retirement, the balances of those who die stay in the annuity pool.

  • Immigrants arrive with the FDC holdings per survivor of their age, as they do with b. This is used in get_F and in the immigrant term of get_I.

  • New SS outputs: F, fdc_contrib, fdc_benefits, fdc_holdings, agg_fdc_contrib, agg_fdc_benefits.

  • Time path. TPI.run_TPI raises NotImplementedError while the pillar is on. Part 3 adds the time path.

Checks (small model, tests/testing_params.json)

fdc_tau r w B F K L RC error
0.00 0.0864 0.9065 2.118 0 1.289 0.4985 1.1e-9
0.05 0.0756 0.9369 2.040 0.244 1.415 0.4978 1.1e-9
0.10 0.0664 0.9651 1.974 0.471 1.537 0.4970 1.1e-9
  • Labor response. Without the accrual term (contributions as a pure tax), L at fdc_tau = 0.10 would be 0.4956 instead of 0.4970. The accrual offsets about half of the labor response.
  • Fund identity. In the steady state, (1 + r_p) F − (FDC bequests) = Σ ω · (start-of-period balances), to rounding. This is tested.
  • Labor wedge. On a consumption path that satisfies the Euler equation, the wedge matches its closed form: pre-retirement contributions are valued like private saving, plus the value of the annuity's mortality credits. This is tested.

Simplifications to review

  • The warm-glow bequest motive is over private savings only, so households do not value the FDC balances bequeathed when they die before retirement.
  • FDC returns are not in before_tax_income or in the income factor calibration.
  • K_d now includes the fund's holdings.

Status

🤖 Generated with Claude Code

Adds fdc_tau (a cohort pension parameter, default 0), fdc_earn_cap,
fdc_earn_cap_factor, and fdc_earn_floor_factor, and the functions that
compute a household's funded defined contribution account over its
life: contributions, balances earning r_p through the retirement
period, a fair annuity-due priced on income-group mortality and the
r_p path, end-of-period holdings, and the accrual derivatives. Not yet
wired into the household problem or aggregates.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov-commenter

codecov-commenter commented Nov 15, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 79.29293% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.76%. Comparing base (9b8a3b4) to head (775a368).

Files with missing lines Patch % Lines
ogcore/pensions.py 68.03% 39 Missing ⚠️
ogcore/household.py 94.73% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1284      +/-   ##
==========================================
- Coverage   79.81%   79.76%   -0.05%     
==========================================
  Files          24       24              
  Lines        6811     6997     +186     
==========================================
+ Hits         5436     5581     +145     
- Misses       1375     1416      +41     
Flag Coverage Δ
unittests 79.76% <79.29%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ogcore/SS.py 92.00% <100.00%> (+0.17%) ⬆️
ogcore/TPI.py 82.19% <100.00%> (+0.05%) ⬆️
ogcore/aggregates.py 100.00% <100.00%> (ø)
ogcore/parameters.py 90.75% <100.00%> (+0.10%) ⬆️
ogcore/household.py 91.22% <94.73%> (+0.44%) ⬆️
ogcore/pensions.py 72.40% <68.03%> (-0.82%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jdebacker and others added 3 commits November 16, 2026 17:12
… accounts

Remove fdc_earn_cap and fdc_earn_cap_factor. With pension_earn_cap true,
FDC contributions are paid only on labor income up to dc_earn_cap_factor
times avg_labor_inc_t1_model_units, the cap shared with the notional
defined contribution system, under any pension_system.

fdc_earn_floor_factor is now a cohort pension parameter entered and
indexed like db_earn_cap_factor and dc_earn_cap_factor (a single value
is value / e^(g_y t); regimes may change it by cohort), so the floor and
the cap move together. fdc_earn_bands returns arrays by period and age,
read down each cohort's diagonal. Specifications checks that the cap is
at least the floor wherever fdc_tau is positive.

Also resolves the leftover conflict markers in default_parameters.json
from the upstream merge and moves the FDC changelog entries to an
Unreleased section.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Households pay FDC contributions and receive annuity benefits through
the budget constraint (outside net_taxes and the government budget).
FOC_labor values the annuity a contribution buys via
fdc_labor_wedge. Fund assets F (aggregates.get_F, in next-period
detrended units like b_{s+1}) add to domestic savings in
get_K_splits; pre-retirement balances of the deceased are bequeathed;
immigrants arrive with their age's FDC holdings per survivor. SS
output adds F and FDC profiles. run_TPI raises NotImplementedError
while fdc_tau > 0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants