Skip to content

Import cbind from BiocGenerics (DelayedArray no longer exports it) - #8

Open
chrispbsmolen wants to merge 1 commit into
PYangLab:mainfrom
chrispbsmolen:fix-cbind-import
Open

chrispbsmolen wants to merge 1 commit into
PYangLab:mainfrom
chrispbsmolen:fix-cbind-import

Conversation

@chrispbsmolen

Copy link
Copy Markdown

Cepo does not install on Bioconductor devel (3.24), and scClassify fails with it because it imports Cepo. Packages need to pass by 20 November for the release.

The install stops with "object 'cbind' is not exported by 'namespace:DelayedArray'". DelayedArray no longer re-exports cbind. The generic lives in BiocGenerics.

This change:

  • uses BiocGenerics::cbind in R/Cepo.R and imports it in NAMESPACE
  • puts BiocGenerics in Imports in place of DelayedArray
  • lists DelayedArray under Suggests, because the vignette loads it

Checked on Linux with R 4.6 and Bioconductor 3.24. This branch passes R CMD check with no errors and no warnings. The same change on the Bioconductor devel copy (1.19.0) also passes, and scClassify then passes unchanged.

The Bioconductor copy still needs the same change pushed to git.bioconductor.org. I'm glad to send it as a patch against that copy if that helps.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant