Repository navigation
Import cbind from BiocGenerics (DelayedArray no longer exports it) - #8
Open
chrispbsmolen wants to merge 1 commit into
Open
chrispbsmolen wants to merge 1 commit into
chrispbsmolen wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cepo does not install on Bioconductor devel (3.24), and scClassify fails with it because it imports Cepo. Packages need to pass by 20 November for the release.
The install stops with "object 'cbind' is not exported by 'namespace:DelayedArray'". DelayedArray no longer re-exports cbind. The generic lives in BiocGenerics.
This change:
BiocGenerics::cbindinR/Cepo.Rand imports it inNAMESPACEChecked on Linux with R 4.6 and Bioconductor 3.24. This branch passes R CMD check with no errors and no warnings. The same change on the Bioconductor devel copy (1.19.0) also passes, and scClassify then passes unchanged.
The Bioconductor copy still needs the same change pushed to git.bioconductor.org. I'm glad to send it as a patch against that copy if that helps.