Repository navigation
Keep the saga ETag when an audit instance lacks the saga - #6048
Merged
Merged
Conversation
rbev
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
A saga usually lives on one audit instance, and every other instance answered
/api/sagas/{id}with a 204 and no ETag. The primary tried to parse that empty body, counted the instance as failed, and the merged saga history went out as incomplete with no ETag. Every audit instance now versions a missing saga, and the primary reads a 204 as an answer.CreatedOnandIdalone: they are inserted and deleted, never updated.Tests
ServiceControl.Audit.Persistence.Tests(shared by all three backends): a missing saga has a version; saga and message-list versions hold across repeated reads and move when a change or message arrives, including when onlyTotal-Countmoves under an unchanged page.ServiceControl.Audit.Persistence.Tests/EFCore: the message-list and saga versions move when a retention sweep and an arrival leave the count unchanged.ServiceControl.Audit.Persistence.Tests.RavenDB: the message-list version moves when expiration removes a message.ServiceControl.UnitTests/ScatterGather: an instance without the saga answers rather than fails, with and without an ETag.