Skip to content

fix modal focus and console errors when showing modal - #3171

Merged
PhilBastian merged 3 commits into
masterfrom
modal_fixes
Oct 21, 2026
Merged

PhilBastian merged 3 commits into
masterfrom
modal_fixes

Conversation

@PhilBastian

@PhilBastian PhilBastian commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor
  • ModalDialog.vue was recently created to unify behaviour across various modal dialogs, however a tweak to the capture focus logic try and ensure compatibility with tests was implemented incorrectly, resulting in console errors
  • Added functionality to store the previously focused element and return focus on modal close
  • Removed copy-paste error referencing bootstrap modal which isn't used by ServicePulse modals

Reviewer Checklist

  • Components are broken down into sensible and maintainable sub-components.
  • Styles are scoped to the component using it. If multiple components need to share CSS, then a .css file is created containing the shared CSS and imported into component scoped style sections.
  • Naming is consistent with existing code, and adequately describes the component or function being introduced
  • Only functions utilizing Vue state or lifecycle hooks are named as composables (i.e. starting with 'use');
  • No module-level state is being introduced. If so, request the PR author to move the state to the corresponding Pinia store.

@PhilBastian PhilBastian self-assigned this Oct 20, 2026
@PhilBastian
PhilBastian merged commit 4d783fa into master Oct 21, 2026
5 checks passed
@PhilBastian
PhilBastian deleted the modal_fixes branch October 21, 2026 01:27
@mikeminutillo mikeminutillo modified the milestone: 2.13.0 Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants