Repository navigation
Fix Sacrifice Support life calculation for totems - #10363
Merged
LocalIdentity merged 1 commit intoOct 29, 2026
Merged
LocalIdentity merged 1 commit into
LocalIdentity merged 1 commit into
Conversation
LocalIdentity
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10291
Description of the problem being solved:
Per the wiki, Sacrifice Support uses totem life. PoB is not using totem life for calculating the damage benefit of Sacrifice Support when it's supporting a totem.
This change generalizes Sacrifice to use "sacrificeLifePercent" and adds that logic to CalcOffence where totem life has already been calculated.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/hVP-LRdejy8Q
Before screenshot:
After screenshot: