Repository navigation
Add missing duration flag to Bladefall, Smoke Mine and Cold Snap - #10384
Merged
LocalIdentity merged 1 commit intoOct 29, 2026
Merged
LocalIdentity merged 1 commit into
LocalIdentity merged 1 commit into
Conversation
These skills have a base skill effect duration but were missing the duration base flag, so their Skill Duration was not shown in the Calcs tab. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
Before / After screenshotsCold Snap — before: after: Bladefall — before: after: Smoke Mine — before: after: |
LocalIdentity
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5125 .
Description of the problem being solved:
Dread Banner and War Banner (the original report) already received the
durationflag in #9559. A comment in this issue listed other skills with the same problem. Of those, Bladefall, Bladefall of Trarthus, Smoke Mine and Cold Snap still have a base skill effect duration but nodurationbase flag, so their Skill Duration was hidden in the Calcs tab.Ethereal Knives, Shattering Steel and Cyclone no longer have a duration in the current game data, so they are left unchanged.
Both the export scripts (
src/Export/Skills) and the generated data (src/Data/Skills) were updated.Steps taken to verify a working solution:
dev(v2.67.2, based on commit 16de4b8), Windows 11Link to a build that showcases this PR:
N/A
Before screenshot:
Skill Duration row missing in Calcs tab
After screenshot:
(screenshots attached in a comment below)
AI disclosure: the investigation and code changes were made with Claude Code (model: Claude Opus 5.5,
claude-opus-5-5); testing in the app and screenshots were done by me.🤖 Generated with Claude Code