Repository navigation
Fix matching socket quality in item comparisons - #10396
Open
AdamZ-8113 wants to merge 1 commit into
Open
AdamZ-8113 wants to merge 1 commit into
AdamZ-8113 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10362
Description of the problem being solved:
When previewing an item with different socket colors, PoB recalculated the item’s stats but did not recalculate which gems matched its sockets. It continued using the gem-quality bonuses from the currently equipped item. This made the tooltip disagree with the result after actually equipping the item.
In the example build, Corpse Fletch showed ~69.6k additional Combined DPS in the tooltip but gave ~75.2k after being equipped.
This is because the comparison calculation used the cached socket match state from the equipped item. It now determines matching socket quality from the item used by the calculation, including socket order, and carries that value into the gem quality breakdown.
Steps taken to verify a working solution:
TestGemSocketQuality_spec.lua: 14 successes, 0 failures.Link to a build that showcases this PR:
https://pob.codes/b/gxbNWwV4BXK
Before screenshot:
After screenshot: