Repository navigation
Take the tutorial's numbers from a run of today's code - #65
Merged
Merged
Conversation
The tutorial's case counts and QC line, and their copies on the front page, the outputs page and the custom-reference page, came from runs in July. Its own commands were run again on CDC1551 and on Sakai against K-12 with --skip_functional_annotation, and the QC line comes from GET_OUTPUTS' own script run on that run's corrected genes. The tutorial also says where --validate_only writes its verdict and where the count of reference proteins is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tutorial says its numbers come from an actual run. They came from runs in July, and today's code gives other ones: the case counts moved, and after #58 the QC line's
pseudogene_countcounts AMAP's own calls, not Mycobrowser's 13. The same numbers were copied to the front page, the outputs page and the custom-reference page.What was run
The tutorial's own commands, on 18 October 2026, with the code of 947a99d (Nextflow 26.10.2,
paururo/amap:latest, the same digest as Docker Hub's), each with--skip_functional_annotationadded:--validate_only, as written (it never reaches eggNOG): 8 s;--ref_annotation ref.gbk --ref_genome ref.fna: 10 tasks, 5 min 47 s.The genomes are the benchmark's copies of the same four NCBI files, fetched with the same URLs this morning; a HEAD request on each URL still answers 200 with a Last-Modified older than that copy.
GET_OUTPUTS only runs after eggNOG, so the QC line comes from GET_OUTPUTS' own script, rendered from
modules/local/get.nfwith the renderertests/test_sample_ids.pyuses, run in the container with Nextflow's docker command on that run's FIX_CDS output, with an eggNOG table that has its header and no rows. None of the six columns the tutorial shows depends on eggNOG, and the tutorial now says how the line was made.Numbers
CDC1551 differs from the benchmark's (2811, 1101, 142) by one or two because the tutorial's FASTA keeps NCBI's "complete sequence" description, which since #62 makes Bakta read it as circular.
Also from the run
--validate_onlyverdict never reaches the console; it is inresults/pipeline_info/validation.log, andtail -n 8of it is the tutorial's excerpt byte for byte. The tutorial now says so..command.out, not printed as the warning said; the tutorial gives thegrepthat finds it.ls -Fso that the listing's slashes are real,amap_report.htmlin it, and which entries a run without eggNOG lacks (this run: noDUPLICATIONS/,PANGENE/orfinal_report.html, as the outputs page says). Without eggNOG the run still writesamap_report.html, so "what you lose" now namesfinal_report.html.Not changed
work/... for one genome is a few GB": 93 MB for CDC1551 without eggNOG. The eggNOG database is built in--eggnog_db, outsidework/, so a full run is probably far below that, but only a run with eggNOG can say.eggnog.nf, not from a run.*-AMAP.clean.faadrops pseudogenes; in this run it keeps 42 of the 123 (export_clean_proteome.pycompares the FASTA ID withsimple_id). That is a code fix, being worked on separately.Checks
tools/build_docs.pyrebuilt the pages (anddocs/about/changelog.html);build_docs.py --checkandtools/check_site.pypass with Python 3.11. The case figures on the tutorial and outputs pages redraw from the new tables. A trial merge with #64 conflicts only in the generateddocs/about/changelog.html: rebuild it withtools/build_docs.pyafter merging either one.