Repository navigation
Return started-sync without awaiting address history sync - #1143
Merged
Merged
Conversation
Awaiting syncAndSubscribeAddresses held the HTTP request open for the full Chronik/DB sync. Fire it in the background, matching the paybutton routes, so the client gets STARTED_SYNC immediately. Co-authored-by: David <Klakurka@users.noreply.github.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
ScottMcDermid
approved these changes
Nov 7, 2026
ScottMcDermid
left a comment
ScottMcDermid
left a comment
Member
There was a problem hiding this comment.
Doesn't appear to break anything
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #
Description
GET /api/address/transactions/[address]waited for the full Chronik and database sync before responding. The route now starts that sync in the background, the same way the paybutton routes do, and returns "Sync started" immediately.Merge this after the
addressExistspool-error fix. Until that lands, a pool timeout is still classified as a missing address, and this change would start a background sync for those failures.Test plan
STARTED_SYNC_200.