Repository navigation
Conversation
Resolve the address once and filter Transaction by addressId so MySQL can use Transaction_addressId_timestamp_idx. Cap this endpoint at 500 rows per page to avoid large offset scans. Co-authored-by: David <Klakurka@users.noreply.github.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #
Description
The address transactions query filtered through the address relation and allowed pages of up to 2000 rows. That missed
Transaction_addressId_timestamp_idxand held pool connections on large offset scans.The handler resolves the address once, queries
TransactionbyaddressId, and caps this endpoint at 500 rows. Other endpoints still use the 2000 limit.Test plan
addressId.tests/unittests/transactionService.test.ts(3 passed).pageSizeabove 500 on this route returnsADDRESS_PAGE_SIZE_LIMIT_EXCEEDED_400.