Repository navigation
Conversation
Classify existing rows and apply status updates outside the interactive transaction, group identical updates into updateMany, and lower the create-path timeout from 45s to 15s so pool connections are released sooner. Co-authored-by: David <Klakurka@users.noreply.github.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #
Description
Bulk transaction persist held one pool connection for the whole classify, insert, and per-row update, with a 45-second interactive-transaction timeout.
Existing-row lookup and status updates now run outside that transaction. Rows that share the same confirmed, timestamp, and orphaned values are updated together with
updateMany. Inserts still use one interactive transaction, with the timeout lowered to 15 seconds.Test plan
persistManyTransactionRowsis not exported, so this path has no direct unit test. Review the grouping key and the insert transaction.