Repository navigation
Conversation
Use getNetworkIdFromSlug instead of querying Network for every upsert. That removes a pool checkout from the cold-address path that surfaced the production timeout on network.findUnique. Co-authored-by: David <Klakurka@users.noreply.github.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #
Description
Creating an address looked up the network with
prisma.network.findUnique. That is the query named in the production pool-timeout error, and the id is already determined by the address prefix (ecashorbitcoincash).upsertAddressnow usesgetNetworkIdFromSlug. An unknown prefix still returns "Invalid network slug."Test plan
networkIdand no longer mocksnetwork.findUnique.tests/unittests/addressService.test.ts(5 passed).