Repository navigation
Centralize two privately duplicated lemmas - #2528
Merged
Merged
Conversation
listAlternates_of_listInterlaces_cons had identical private copies in PolynomialValueEulerNumerator/Interlacing and Interlacing/QuadraticRemainderCriterion; it now lives once, public, in Basic/RootLists next to the definitions. iteratedPDerivAt_mul_of_pderiv_zero had private copies for ℂ and ℝ; it now lives once, for any commutative semiring, next to iteratedPDerivAt in LiebSokalOperator. Found by scripts/golf/dupbody.py. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repo cleanup:
scripts/golf/dupbody.pyreports one identical declaration pair library-wide, plus one ℂ/ℝ pair with identical proofs.listAlternates_of_listInterlaces_cons: one public copy inBasic/RootLists.lean(next toListInterlaces/ListAlternates) replaces the private copies inPolynomialValueEulerNumerator/Interlacing.leanandInterlacing/QuadraticRemainderCriterion.lean.iteratedPDerivAt_mul_of_pderiv_zero: one public lemma for any commutative semiring inLiebSokalOperator.leanreplaces the private ℂ copy (BorceaBranden/FiniteOrderWeylPreserver.lean) and ℝ copy (FiniteFreeAdditive/Stability.lean).Net −19 lines. Local checks: focused builds of the four consumers,
runLinteron the two modules gaining the lemmas.🤖 Generated with Claude Code