Skip to content

audit(gc): revalidate RSS change source pins and page-size cache - #11879

Closed
proggeramlug wants to merge 3 commits into
mainfrom
gc-rss-audit-followup-20261004
Closed

proggeramlug wants to merge 3 commits into
mainfrom
gc-rss-audit-followup-20261004

Conversation

@proggeramlug

Copy link
Copy Markdown
Contributor

Follow-up for merged #11781: classify the new page-size cache as a numeric byte count, and re-audit/re-pin the non-moving census snapshot contract after the collection-entry advice and post-sweep changes. No runtime behavior or shape-model change.

The holder audit no longer reports either changed source pin; the thread-exit audit no longer reports SIZE. Remaining failures also occur on clean pre-merge main and are outside this patch. The full landing runtime, stdlib, FFI/event and selected GC integrations passed; complete gate classification and application evidence are being preserved. The pending-mark-frontier experiment remains on a separate branch.

@coderabbitai

coderabbitai Bot commented Oct 4, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@TheHypnoo TheHypnoo added area:tooling-ci CLI driver, scripts, CI, release effort:S Hours: one local fix impact:low Edge case or single test type:chore Refactor, CI, docs, cleanup labels Nov 18, 2026
@TheHypnoo

Copy link
Copy Markdown
Member

Closing this as superseded. Both pins it refreshes are already on main in a later form: the cold-block page-size cache (arena/block/decommit.rs SIZE) is classified no_heap_address in scripts/thread_exit_address_globals.json since #12025, and the PASS1_MARKED non-moving census window was re-audited and re-pinned against the current gc/cycle.rs / gc/mod.rs in #14757 (46411b9). The source hashes here predate those changes, so landing them would re-stale the pins, and the branch now conflicts with main. The audit snapshot files are point-in-time evidence that the later re-audits already cover.

@TheHypnoo TheHypnoo closed this Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:tooling-ci CLI driver, scripts, CI, release effort:S Hours: one local fix impact:low Edge case or single test type:chore Refactor, CI, docs, cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants