Repository navigation
link: record the default hot-text order again on the current runtime (chess peak RSS back to or below c10e0055ee) - #14700
Merged
Merged
Conversation
added 2 commits
November 14, 2026 15:42
…(new start-up and hot-path functions were outside the run); the previous recording's other keys stay in a carried tier
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chess peak RSS rose by 256 to 512 KiB on main between c10e005 and fee15e5, and hello2 rose with it. A per-commit bisect (one release build per first-parent commit on qb10) shows four steps:
The #14679, #14685 and #14690 steps are placement. They added runtime functions that ordinary programs run at start-up or on the hot path, and those functions were outside the default hot-text order (recorded on 7108c84). Each one maps another 64 KiB window of the runtime text.
perf record -e page-faults -don symbol builds shows 4 more faults on the binary (anonymous faults equal). The first touch of each new window is inAtomTable::replace_from,prune_property_atoms,computed_key_complete,gc_budgeted_step_work_units_inner_with_progressandpublish_unbuilt_holder(#14679), theoccupancy_max_survivalsOnceLock (#14685), andstore_proven_own_slot_slow(#14690). None of them was listed.Change
hot_text_order.txtonly. It is recorded again with the hotorder recipe on fee15e5: 309 programs (parity sample, scoreboard, chess x4, hello2; tssrc and skin left out, as in hotorder2), 253 train and 53 held, thenscripts/hot_text_order.py build. The previous recording's other keys that still exist (361) follow as a trailing# tier carriedclass.The plain re-recording (6 713 keys) won chess back, but it lost hello2: +256 KiB, 4 864 x10. Its start-up functions (
ensure_element_shape,js_array_ensure_element_shape_ordinary) run in only one train program, so the two-program threshold drops them, although the old list had them. Variants were measured with--min-programs 1, with and without the carried tier. List plus carried is the only one that is no worse than c10e005 on perft, evaluate, legal and hello2.Layout only: no IR, object or instruction changes.
PERRY_HOT_TEXT_ORDER=offis unchanged.Numbers (qb10, one session; fee15e5 vs fee15e5 + this list; instructions:u x3 interleaved, peak RSS median of 10 KiB)
Not fixed here: the #14676 search +88 KiB is heap, not layout. The file-backed faults are equal, and the GC arena keeps one more 2 MiB block resident at the peak (one fewer
MADV_DONTNEED+MADV_HUGEPAGEpair).Tests
scripts/hot_text_order.py selftestok.check --require-coverageon the release build: names 7 074 of 7 074 (core 0 missing), smoke outside the hot run 0.07%.cargo test --release -p perry --bin perry -- hot_text_order hot_data_order compile_env: 64 passed.cargo test --release -p perry --test function_order: 6 passed.PERRY_HOT_TEXT_ORDERswitch.Not run
Full suites, IR census, vf / check-mode corpus, tssrc, Supabase, skin size, parity corpus RSS on/off, the held-out corpus RSS, aarch64 / musl / lld measurement.