Skip to content

ci: fix rustc warnings and stale lint gate expectations - #14785

Merged
proggeramlug merged 1 commit into
mainfrom
cwn/ci-green
Nov 16, 2026
Merged

proggeramlug merged 1 commit into
mainfrom
cwn/ci-green

Conversation

@proggeramlug

@proggeramlug proggeramlug commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

CI on main is red in lint and warnings (run 43834597356). This fixes the cheap part.

warnings (rustc -D warnings, host-compatible all-targets): removed 2 unused imports, renamed 11 unused bindings to _x (the calls still run), dropped an unused mut, cast a function item through *const (), deleted the dead constructor_store_keys wrapper (its _of variant is the one in use).

lint: shape_descriptor_census.py patterns refreshed to current code (bag-first read route in probe_get_at, shape-directory argument of js_put_value_set_dynamic, cfg(perry_gc_instruments) prelude of perry_probe_get); local_binding_type allowlist entry for iterator_member_site (runtime-validated by emit_iterator_call); memory-model.md fact now INTERNAL_WORD_TAG (INT32_TAG was removed in #14658).

Run locally: shape_descriptor_census.py, local_binding_type_audit.py, check_gc_doc_claims.py all pass; cargo check --keep-going with -D warnings.

Still red after this (dead code owned by other lanes, not touched): wpfacts array_method_on_prim, ctor_phase analyze/analyze_in/analyze_in_present, provenance take_chain, tests/peelk20 src/USE; codegen NON_CONFIGURABLE; runtime snap_image/format.rs REGION_* and parse_claims_blob/claims_replay_matches.

Remove unused imports, bind or rename unused variables, drop an unused mut,
cast a function item through a pointer, delete the dead constructor_store_keys
wrapper. Refresh the shape-descriptor census patterns to the current
bag-first read route, the shape-directory argument of the dynamic store and
the instrumented-build prelude of perry_probe_get; allowlist the iterator
member site local-type read; point the memory-model doc fact at
INTERNAL_WORD_TAG (the INT32 tag no longer exists).
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@proggeramlug
proggeramlug marked this pull request as ready for review November 16, 2026 10:16
@proggeramlug
proggeramlug merged commit 2fae3aa into main Nov 16, 2026
117 of 124 checks passed
@proggeramlug
proggeramlug deleted the cwn/ci-green branch November 16, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants