Repository navigation
ci: fix rustc warnings and stale lint gate expectations - #14785
Merged
Merged
Conversation
Remove unused imports, bind or rename unused variables, drop an unused mut, cast a function item through a pointer, delete the dead constructor_store_keys wrapper. Refresh the shape-descriptor census patterns to the current bag-first read route, the shape-directory argument of the dynamic store and the instrumented-build prelude of perry_probe_get; allowlist the iterator member site local-type read; point the memory-model doc fact at INTERNAL_WORD_TAG (the INT32 tag no longer exists).
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on main is red in lint and warnings (run 43834597356). This fixes the cheap part.
warnings (rustc -D warnings, host-compatible all-targets): removed 2 unused imports, renamed 11 unused bindings to
_x(the calls still run), dropped an unusedmut, cast a function item through*const (), deleted the deadconstructor_store_keyswrapper (its_ofvariant is the one in use).lint: shape_descriptor_census.py patterns refreshed to current code (bag-first read route in probe_get_at, shape-directory argument of js_put_value_set_dynamic, cfg(perry_gc_instruments) prelude of perry_probe_get); local_binding_type allowlist entry for iterator_member_site (runtime-validated by emit_iterator_call); memory-model.md fact now INTERNAL_WORD_TAG (INT32_TAG was removed in #14658).
Run locally: shape_descriptor_census.py, local_binding_type_audit.py, check_gc_doc_claims.py all pass; cargo check --keep-going with -D warnings.
Still red after this (dead code owned by other lanes, not touched): wpfacts array_method_on_prim, ctor_phase analyze/analyze_in/analyze_in_present, provenance take_chain, tests/peelk20 src/USE; codegen NON_CONFIGURABLE; runtime snap_image/format.rs REGION_* and parse_claims_blob/claims_replay_matches.