Skip to content

fix: refresh census size exemption and wasm runtime ABI table - #14811

Merged
proggeramlug merged 1 commit into
mainfrom
fix/main-hygiene-3
Nov 16, 2026
Merged

proggeramlug merged 1 commit into
mainfrom
fix/main-hygiene-3

Conversation

@proggeramlug

@proggeramlug proggeramlug commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Both reported failures reproduce on base 6957c125b60f0240ced28836df95fb8aa3b65064. The snapshot census runner has 4,942 code lines, but its existing exemption asserts 4,875. The generated wasm runtime ABI table is missing js_parse_int_value and js_loop_settle_once.

The change refreshes only the runner's existing exemption and regenerates the ABI table with the repository's tool. The new rows are js_parse_int_value\tf64\tf64,f64 and js_loop_settle_once\tvoid\t (tabs shown escaped here). No runtime implementation changes.

The size script explicitly supports --update, and commit dd083f33ef uses this convention for the same runner. Its exemption assigns the split to the census owner. Splitting a roughly 5,000-code-line instrumentation module would exceed this small hygiene repair. The updater was run, then unrelated count changes were discarded to keep this lane scoped.

Validation:

  • Mac: ./scripts/check_file_size.sh failed on the base, confirming the runner mismatch plus eight other stale exemptions and eight unexempted oversized files.
  • Mac: python3 scripts/runtime_abi_check.py --check-wasm-abi failed on the base with the stale-table diagnostic.
  • Mac: ./scripts/check_file_size.sh --update and python3 scripts/runtime_abi_check.py --emit-wasm-abi succeeded; the latter emitted 5,364 symbols.
  • qb10: python3 scripts/runtime_abi_check.py --self-test, --check-native, the no-argument report, and --check-wasm-abi passed. Native class, width, arity and missing-return mismatch counts are all zero. The report still lists wasm-only adaptations and bookkeeping findings; passing does not mean those counts are zero.
  • qb10: ./scripts/check_file_size.sh still exits 1: eight unrelated stale exemptions and eight oversized files remain, exactly as on the base. The runner mismatch is gone. See HANDOFF-hyg3.md for the output.
  • Mac: CARGO_TARGET_DIR="$HOME/projects/perry/target-check-shared" LLVM_SYS_221_PREFIX=/opt/homebrew/opt/llvm@22 cargo check -p perry-codegen --features target-wasi passed in 2m 39s. It emitted 39 LLVM C++ header warnings and two Rust dead-code warnings (effects_of, emit_late_slot_holds_hole).
  • git diff --check passed.

CI guards: .github/workflows/test.yml File size limit and Native runtime ABI consistency; .github/workflows/compiler-runtime.yml Runtime ABI check (self-test/report) and wasm32 runtime ABI table is current. These are the specific checks exercised, not the whole workflows.

Not run: release builds, Rust tests, full lint/test suites, WASI compilation/link/execution, chess gate, instruction/RSS/startup/binary-size measurements. The lane task requests only the named guards and cargo check; no performance result is claimed. No Mac tests were run; the Python checker self-test ran on qb10.

Summary by CodeRabbit

  • Chores
    • Updated the recorded size limit for a source file.

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Explain Change →

Walkthrough

The file-size check script now asserts 4942 code lines for crates/perry-runtime/src/snap_census/runner.rs, replacing 4875.

Changes: File-size allowlist

Layer / File(s) Summary
Update the asserted line count
scripts/check_file_size.sh
The allowlist count for the snap census runner changed from 4875 to 4942.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Possibly related PRs

Suggested reviewers: thehypnoo

Merge Risk: Minimal · up to 1232a

This updates a file-size exemption count and does not change runtime behavior. The risk to merging is minimal.

Pre-merge checks: Passed 2

Check name Status Explanation
Title check Passed The title names both changes in the PR: the census size exemption refresh in scripts/check_file_size.sh and the wasm runtime ABI table update. It is short, specific, and uses the repository's fix: pre…
Description check Passed The description follows the template's main sections: Summary, Changes, Test plan, and related context. It explains the runner line-count mismatch, the missing ABI rows, and the validation steps run o…
Full details: Title check

Explanation

The title names both changes in the PR: the census size exemption refresh in scripts/check_file_size.sh and the wasm runtime ABI table update. It is short, specific, and uses the repository's fix: prefix convention. It does not cover every detail, which is acceptable.

Full details: Description check

Explanation

The description follows the template's main sections: Summary, Changes, Test plan, and related context. It explains the runner line-count mismatch, the missing ABI rows, and the validation steps run on Mac and qb10. It gives no explicit 'Related issue' entry, and the template checklist items are not all ticked. The template's Related issue section is missing, and the Checklist section is not addressed. The Summary and Changes content is clear, so the description is mostly complete.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@proggeramlug
proggeramlug merged commit 547868d into main Nov 16, 2026
6 of 7 checks passed
@proggeramlug
proggeramlug deleted the fix/main-hygiene-3 branch November 16, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant