You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: refresh census size exemption and wasm runtime ABI table - #14811
Both reported failures reproduce on base 6957c125b60f0240ced28836df95fb8aa3b65064. The snapshot census runner has 4,942 code lines, but its existing exemption asserts 4,875. The generated wasm runtime ABI table is missing js_parse_int_value and js_loop_settle_once.
The change refreshes only the runner's existing exemption and regenerates the ABI table with the repository's tool. The new rows are js_parse_int_value\tf64\tf64,f64 and js_loop_settle_once\tvoid\t (tabs shown escaped here). No runtime implementation changes.
The size script explicitly supports --update, and commit dd083f33ef uses this convention for the same runner. Its exemption assigns the split to the census owner. Splitting a roughly 5,000-code-line instrumentation module would exceed this small hygiene repair. The updater was run, then unrelated count changes were discarded to keep this lane scoped.
Validation:
Mac: ./scripts/check_file_size.sh failed on the base, confirming the runner mismatch plus eight other stale exemptions and eight unexempted oversized files.
Mac: python3 scripts/runtime_abi_check.py --check-wasm-abi failed on the base with the stale-table diagnostic.
Mac: ./scripts/check_file_size.sh --update and python3 scripts/runtime_abi_check.py --emit-wasm-abi succeeded; the latter emitted 5,364 symbols.
qb10: python3 scripts/runtime_abi_check.py --self-test, --check-native, the no-argument report, and --check-wasm-abi passed. Native class, width, arity and missing-return mismatch counts are all zero. The report still lists wasm-only adaptations and bookkeeping findings; passing does not mean those counts are zero.
qb10: ./scripts/check_file_size.sh still exits 1: eight unrelated stale exemptions and eight oversized files remain, exactly as on the base. The runner mismatch is gone. See HANDOFF-hyg3.md for the output.
Mac: CARGO_TARGET_DIR="$HOME/projects/perry/target-check-shared" LLVM_SYS_221_PREFIX=/opt/homebrew/opt/llvm@22 cargo check -p perry-codegen --features target-wasi passed in 2m 39s. It emitted 39 LLVM C++ header warnings and two Rust dead-code warnings (effects_of, emit_late_slot_holds_hole).
git diff --check passed.
CI guards: .github/workflows/test.yml File size limit and Native runtime ABI consistency; .github/workflows/compiler-runtime.yml Runtime ABI check (self-test/report) and wasm32 runtime ABI table is current. These are the specific checks exercised, not the whole workflows.
Not run: release builds, Rust tests, full lint/test suites, WASI compilation/link/execution, chess gate, instruction/RSS/startup/binary-size measurements. The lane task requests only the named guards and cargo check; no performance result is claimed. No Mac tests were run; the Python checker self-test ran on qb10.
Summary by CodeRabbit
Chores
Updated the recorded size limit for a source file.
PerryTS/perry#14699: This PR also changes the file-size gate and addresses file-size gate failures.
PerryTS/perry#14604: This PR refreshes file-size counts in the same check script.
Suggested reviewers:thehypnoo
Merge Risk: Minimal · up to 1232a
This updates a file-size exemption count and does not change runtime behavior. The risk to merging is minimal.
Pre-merge checks: 2
Check name
Status
Explanation
Title check
The title names both changes in the PR: the census size exemption refresh in scripts/check_file_size.sh and the wasm runtime ABI table update. It is short, specific, and uses the repository's fix: pre…
Description check
The description follows the template's main sections: Summary, Changes, Test plan, and related context. It explains the runner line-count mismatch, the missing ABI rows, and the validation steps run o…
Full details: Title check
Explanation
The title names both changes in the PR: the census size exemption refresh in scripts/check_file_size.sh and the wasm runtime ABI table update. It is short, specific, and uses the repository's fix: prefix convention. It does not cover every detail, which is acceptable.
Full details: Description check
Explanation
The description follows the template's main sections: Summary, Changes, Test plan, and related context. It explains the runner line-count mismatch, the missing ABI rows, and the validation steps run on Mac and qb10. It gives no explicit 'Related issue' entry, and the template checklist items are not all ticked. The template's Related issue section is missing, and the Checklist section is not addressed. The Summary and Changes content is clear, so the description is mostly complete.
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both reported failures reproduce on base
6957c125b60f0240ced28836df95fb8aa3b65064. The snapshot census runner has 4,942 code lines, but its existing exemption asserts 4,875. The generated wasm runtime ABI table is missingjs_parse_int_valueandjs_loop_settle_once.The change refreshes only the runner's existing exemption and regenerates the ABI table with the repository's tool. The new rows are
js_parse_int_value\tf64\tf64,f64andjs_loop_settle_once\tvoid\t(tabs shown escaped here). No runtime implementation changes.The size script explicitly supports
--update, and commitdd083f33efuses this convention for the same runner. Its exemption assigns the split to the census owner. Splitting a roughly 5,000-code-line instrumentation module would exceed this small hygiene repair. The updater was run, then unrelated count changes were discarded to keep this lane scoped.Validation:
./scripts/check_file_size.shfailed on the base, confirming the runner mismatch plus eight other stale exemptions and eight unexempted oversized files.python3 scripts/runtime_abi_check.py --check-wasm-abifailed on the base with the stale-table diagnostic../scripts/check_file_size.sh --updateandpython3 scripts/runtime_abi_check.py --emit-wasm-abisucceeded; the latter emitted 5,364 symbols.python3 scripts/runtime_abi_check.py --self-test,--check-native, the no-argument report, and--check-wasm-abipassed. Native class, width, arity and missing-return mismatch counts are all zero. The report still lists wasm-only adaptations and bookkeeping findings; passing does not mean those counts are zero../scripts/check_file_size.shstill exits 1: eight unrelated stale exemptions and eight oversized files remain, exactly as on the base. The runner mismatch is gone. See HANDOFF-hyg3.md for the output.CARGO_TARGET_DIR="$HOME/projects/perry/target-check-shared" LLVM_SYS_221_PREFIX=/opt/homebrew/opt/llvm@22 cargo check -p perry-codegen --features target-wasipassed in 2m 39s. It emitted 39 LLVM C++ header warnings and two Rust dead-code warnings (effects_of,emit_late_slot_holds_hole).git diff --checkpassed.CI guards:
.github/workflows/test.ymlFile size limit and Native runtime ABI consistency;.github/workflows/compiler-runtime.ymlRuntime ABI check (self-test/report) and wasm32 runtime ABI table is current. These are the specific checks exercised, not the whole workflows.Not run: release builds, Rust tests, full lint/test suites, WASI compilation/link/execution, chess gate, instruction/RSS/startup/binary-size measurements. The lane task requests only the named guards and cargo check; no performance result is claimed. No Mac tests were run; the Python checker self-test ran on qb10.
Summary by CodeRabbit