Repository navigation
lint(global-sink): re-audit changed review sources; review tui input READER - #14846
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Turns the
lintstep "Per-test global sinks" green onmain. Re-audits the 13 asserted-global reviews whose pinned sources changed, and reviews the new asserted globaltui/input.rs::READER(#14552).Changes
scripts/global_sink_asserted_reviews.json: re-pins the sha256 of the 8 changed source files and appends a dated re-audit note to each affected claim, naming the commits read.layout_desc.rs(954fbcfc35): adds a read-only query and no descriptor writer.alloc_life.rs,life.rsandlife_measure.rs(fix(runtime): header reads the address-classification audit flags go through the checked probes #14760): header reads now go throughaddr_class::try_read_gc_header. The reviewed statics are untouched.error_stack_clone_tests.rs(refactor(runtime): read StringHeader payloads through string_data at the eight new open-coded sites #14751): reads the payload throughstring_data.GETSis untouched.shapes.rs: the new mint-record tests callfresh_key.Nis still never asserted.tui/input.rs(fix(tui): stop and restart the Unix input reader cleanly #14552):reset()is nowpub(super)forinput/reader_tests.rs. Those tests holdserial()through it and touch neitherCAPTUREDnorINPUT_BYTES_MODE.READER. Its one asserting test,enable_restarts_after_eof, runs intest_isolation::in_own_processunderserial(). On top of that,panic-abort-testsgives every test its own process.Related issue
n/a
Test plan
python3 scripts/global_sink_isolation.py --self-test: passpython3 scripts/global_sink_isolation.py: pass. It fails on172a9354c3with 13 "changed asserted-global review source" and 1 "NEW ASSERTED GLOBAL".