Skip to content

lint(global-sink): re-audit changed review sources; review tui input READER - #14846

Merged
proggeramlug merged 2 commits into
mainfrom
ci-global-sink-reviews
Nov 16, 2026
Merged

proggeramlug merged 2 commits into
mainfrom
ci-global-sink-reviews

Conversation

@TheHypnoo

@TheHypnoo TheHypnoo commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Summary

Turns the lint step "Per-test global sinks" green on main. Re-audits the 13 asserted-global reviews whose pinned sources changed, and reviews the new asserted global tui/input.rs::READER (#14552).

Changes

Related issue

n/a

Test plan

  • python3 scripts/global_sink_isolation.py --self-test: pass
  • python3 scripts/global_sink_isolation.py: pass. It fails on 172a9354c3 with 13 "changed asserted-global review source" and 1 "NEW ASSERTED GLOBAL".

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@proggeramlug
proggeramlug merged commit ea4339a into main Nov 16, 2026
22 checks passed
@proggeramlug
proggeramlug deleted the ci-global-sink-reviews branch November 16, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants