Skip to content

style: cargo fmt the five files main left unformatted - #14868

Merged
TheHypnoo merged 3 commits into
PerryTS:mainfrom
raliclo:fix/main-red-fmt
Nov 18, 2026
Merged

TheHypnoo merged 3 commits into
PerryTS:mainfrom
raliclo:fix/main-red-fmt

Conversation

@raliclo

@raliclo raliclo commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

cargo fmt --all -- --check (lint) fails on main 028b066 in five files that landed unformatted on 2026-11-16. This formats them; nothing else changes.

Changes

  • crates/perry-runtime/src/gc/tests/runtime_roots/json_shape_template.rs (last changed by 60840f8)
  • crates/perry-runtime/src/object/native_module.rs (560ede2)
  • crates/perry-wpfacts/src/units.rs (62ce636)
  • crates/perry/src/commands/compile/collect_modules/feature_detect.rs (63d4014)
  • crates/perry/src/commands/compile/optimized_libs/tests.rs (2955500)

Related issue

Refs #14595 (main CI reds; same class as #14699).

Test plan

  • main 028b066: cargo fmt --all -- --check → exit 1, Diff in the five files above

  • this branch: cargo fmt --all -- --check → exit 0

  • BASE_SHA=upstream/main bash scripts/run_lint_gates.sh on this branch (macOS): 17 FAIL, i.e. the 18 gates that fail with only the companion test-warnings branch applied minus Check formatting; nothing new. The others are macOS-environment (cargo xwin without the step's OpenSSL stub, npm staging without llvm-objcopy on PATH, all-targets warnings from Linux-only snap_image code) or other open reds on main.

  • I have NOT bumped the workspace version or edited CHANGELOG.md

  • Commit follows the style: prefix convention

🤖 Generated with Claude Code

https://claude.ai/code/session_01CUQanVsnitcrmYLAWWPc3p

Summary by CodeRabbit

  • Style
    • Updated code formatting across several areas, including tests and compiler-related logic.
    • No user-facing behavior or functionality changed.

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The pull request reformats Rust code and tests across runtime, compiler, and wpfacts crates. It also adds a changelog entry. The summaries report no behavior or visibility changes.

Changes: Rust Formatting Updates

Layer / File(s) Summary
Apply formatting changes
crates/perry-runtime/src/..., crates/perry/src/commands/compile/..., crates/perry-wpfacts/src/..., changelog.d/14868-main-red-fmt.md
Rust declarations, expressions, and tests are reformatted. The changelog records the formatting pass.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related PRs

  • PerryTS/perry#14604: This PR also includes formatting changes related to a cargo fmt --all -- --check failure on main. The summaries do not confirm file overlap.
  • PerryTS/perry#14699: This PR also includes a cargo fmt fix for main. The summaries do not confirm file overlap.

Suggested reviewers: proggeramlug, thehypnoo

Merge Risk: Minimal · up to b330c

This change only reformats Rust code and adds a changelog entry. It should not change runtime behavior, and the merge risk is minimal.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "style: cargo fmt the five files main left unformatted" names the main change: formatting five Rust files that fail cargo fmt --all -- --check on main. The summaries confirm only formattin…
Description check Passed The description follows the template's main sections. It gives a clear Summary, lists the five changed files, and links a related issue (Refs #14595). The test plan lists commands run and results, and…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "style: cargo fmt the five files main left unformatted" names the main change: formatting five Rust files that fail cargo fmt --all -- --check on main. The summaries confirm only formatting-level edits with no behavior change, so the title matches the changeset.

Full details: Description check

Explanation

The description follows the template's main sections. It gives a clear Summary, lists the five changed files, and links a related issue (Refs #14595). The test plan lists commands run and results, and the checklist confirms no version bump or CHANGELOG edit. Gaps: the Type of change and Platforms checkboxes are not ticked, and the 'Tested on' line is empty. The template also asks for a changelog.d entry under crates/, but the summary shows one exists (changelog.d/14868-main-red-fmt.md), so that requirement is met. The description also omits the template's 'One logical change' note but this is a minor point.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
Fix failing CI checks

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1076e00c-29e6-4046-91d8-52180e237d2e
Commits

Reviewing files that changed from the base of the PR and between c218ca3 and b330c24.

Files selected for processing: 7

  • changelog.d/14868-main-red-fmt.md
  • crates/perry-runtime/src/object/global_this/populate.rs
  • crates/perry-runtime/src/object/global_this/two_phase_tests.rs
  • crates/perry-runtime/src/snap_image/tests.rs
  • crates/perry-wpfacts/src/builtins.rs
  • crates/perry-wpfacts/src/builtins/collections.rs
  • crates/perry-wpfacts/src/tests.rs
Files skipped from review as they are similar to previous changes: 1

  • changelog.d/14868-main-red-fmt.md

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

@TheHypnoo TheHypnoo added area:tooling-ci CLI driver, scripts, CI, release effort:S Hours: one local fix impact:high Common programs break, platform or CI blocked type:chore Refactor, CI, docs, cleanup labels Nov 18, 2026
ralic and others added 3 commits November 18, 2026 21:04
`cargo fmt --all -- --check` fails on main 028b066 in five files; the commit that last changed each (all 2026-11-16):

- crates/perry-runtime/src/gc/tests/runtime_roots/json_shape_template.rs (60840f8)
- crates/perry-runtime/src/object/native_module.rs (560ede2)
- crates/perry-wpfacts/src/units.rs (62ce636)
- crates/perry/src/commands/compile/collect_modules/feature_detect.rs (63d4014)
- crates/perry/src/commands/compile/optimized_libs/tests.rs (2955500)

Formatting only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CUQanVsnitcrmYLAWWPc3p
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CUQanVsnitcrmYLAWWPc3p
@TheHypnoo
TheHypnoo merged commit a29a806 into PerryTS:main Nov 18, 2026
100 of 108 checks passed
@raliclo
raliclo deleted the fix/main-red-fmt branch November 18, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:tooling-ci CLI driver, scripts, CI, release effort:S Hours: one local fix impact:high Common programs break, platform or CI blocked type:chore Refactor, CI, docs, cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants