Skip to content

fix(ci): resolve relocated WASI component fixture dependency - #14932

Merged
TheHypnoo merged 1 commit into
PerryTS:mainfrom
wsafight:fix/ci-component-fixture-path
Nov 18, 2026
Merged

TheHypnoo merged 1 commit into
PerryTS:mainfrom
wsafight:fix/ci-component-fixture-path

Conversation

@wsafight

@wsafight wsafight commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

wasi-components builds its WASI runtime and then stops in prepare_rust_host_manifest with AssertionError: Rust host path changed: crates/perry-wasi. The relocated fixture's manifest points six directories up to the workspace, while the preparation script still searches for the old four-directory path. Match the actual source manifest so the copied host keeps using the workspace's WASI provider.

Changes

  • scripts/component_guest_acceptance.py: update the expected in-tree dependency path; preserve the exact-one-match assertion.
  • tests/tooling/infrastructure/test_wasi_host_qualification.py: copy the real fixture to an arbitrary temporary directory and assert that only its dependency path becomes absolute. Also assert that a missing expected dependency still rejects the manifest without changing it.

Related issue

CI investigation in #14919. The observed failure is in this WASI component job. No existing open PR covers this fixture-preparation failure.

Independent blockers: #14928 fixes e2e scope selection; #14929 fixes the compiler cache-input audit. Neither unrelated change is bundled here.

Test plan

  • New regression against unchanged script: 7 passed, 1 failed, with the exact CI assertion.
  • python3 tests/tooling/infrastructure/test_wasi_host_qualification.py -v with the fix: 8 passed.
  • python3 tests/tooling/infrastructure/test_wasi_release.py: 19 passed.
  • python3 scripts/check_test_registration.py.
  • git diff --check.
  • BASE_SHA=upstream/main CARGO_NET_OFFLINE=true SKIP_COMPILE_GATES=1 bash scripts/run_lint_gates.sh — 17/142 commands fail; 2 CI-only arms skipped, compile tier explicitly skipped. A clean detached checkout at the same 2ea9a8be base reports the exact same 17 failing commands. No new failing gate command and no full-lint pass is claimed.
  • Full WASI guest-component execution has not been rerun locally; the tests verify the previously failing preparation step, not later component behavior.

Checklist

  • CI-only script/test change, no workspace version bump, crate/API change, changelog requirement or CHANGELOG.md edit.
  • No skipped component phase or weakened acceptance assertion.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected Rust host dependency path resolution so prepared manifests point to the workspace’s perry-wasi crate.
  • Tests
    • Added coverage for valid and invalid dependency paths, including checks that source manifests remain unchanged.

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Rust-host manifest preparation now matches a four-level relative dependency path instead of a six-level path. Tests check the resolved workspace crate path, preservation of the fixture, and rejection of an unexpected dependency path.

Changes: Rust-host manifest path

Layer / File(s) Summary
Correct and verify the manifest dependency path
scripts/component_guest_acceptance.py, tests/tooling/infrastructure/test_wasi_host_qualification.py
The helper now matches the four-level relative path. Tests check the resolved workspace crate path, confirm that the fixture remains unchanged, and verify that an unexpected dependency path raises an AssertionError.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: thehypnoo

Merge Risk: Minimal · up to 54169

This restores the WASI component job's manifest preparation so it matches the relocated fixture's dependency path. The change affects CI scripts and tests only, and no merge-blocking risk remains.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "fix(ci): resolve relocated WASI component fixture dependency" matches the main change. The script now expects the relocated fixture's dependency path (four parent traversals instead of six)…
Description check Passed The description follows the repository template's main sections: Summary, Changes, Related issue, Test plan, and Checklist. The Summary explains the failure and the fix. Changes lists both files. Rela…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "fix(ci): resolve relocated WASI component fixture dependency" matches the main change. The script now expects the relocated fixture's dependency path (four parent traversals instead of six), and the new tests cover that path. It follows the repository's conventional prefix style and names the affected area without vague terms.

Full details: Description check

Explanation

The description follows the repository template's main sections: Summary, Changes, Related issue, Test plan, and Checklist. The Summary explains the failure and the fix. Changes lists both files. Related issue cites #14919 and the CI job, and it names the independent blockers #14928 and #14929. The Test plan gives concrete commands and results, and it states which checks were not run. The Checklist confirms no version bump or CHANGELOG edit. The template's Screenshots section is optional and absent. One point is weak: the template asks for a Changes list with file paths, which is present. The description does not repeat the no-version-bump and no-CHANGELOG reminders in the template comment, but the checklist covers them.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 152df97a-6919-49e9-aa24-80cda57d624b
Commits

Reviewing files that changed from the base of the PR and between 2ea9a8b and 541695d.

Files selected for processing: 2

  • scripts/component_guest_acceptance.py
  • tests/tooling/infrastructure/test_wasi_host_qualification.py

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.

@wsafight
wsafight marked this pull request as ready for review November 17, 2026 16:23
@TheHypnoo TheHypnoo added area:tooling-ci CLI driver, scripts, CI, release effort:S Hours: one local fix impact:med A feature, module, package or platform subset platform:wasm Specific to wasm type:chore Refactor, CI, docs, cleanup labels Nov 18, 2026
@TheHypnoo
TheHypnoo merged commit f17d2d8 into PerryTS:main Nov 18, 2026
234 of 404 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:tooling-ci CLI driver, scripts, CI, release effort:S Hours: one local fix impact:med A feature, module, package or platform subset platform:wasm Specific to wasm type:chore Refactor, CI, docs, cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants