You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
wasi-components builds its WASI runtime and then stops in prepare_rust_host_manifest with AssertionError: Rust host path changed: crates/perry-wasi. The relocated fixture's manifest points six directories up to the workspace, while the preparation script still searches for the old four-directory path. Match the actual source manifest so the copied host keeps using the workspace's WASI provider.
Changes
scripts/component_guest_acceptance.py: update the expected in-tree dependency path; preserve the exact-one-match assertion.
tests/tooling/infrastructure/test_wasi_host_qualification.py: copy the real fixture to an arbitrary temporary directory and assert that only its dependency path becomes absolute. Also assert that a missing expected dependency still rejects the manifest without changing it.
Related issue
CI investigation in #14919. The observed failure is in this WASI component job. No existing open PR covers this fixture-preparation failure.
Independent blockers: #14928 fixes e2e scope selection; #14929 fixes the compiler cache-input audit. Neither unrelated change is bundled here.
Test plan
New regression against unchanged script: 7 passed, 1 failed, with the exact CI assertion.
python3 tests/tooling/infrastructure/test_wasi_host_qualification.py -v with the fix: 8 passed.
BASE_SHA=upstream/main CARGO_NET_OFFLINE=true SKIP_COMPILE_GATES=1 bash scripts/run_lint_gates.sh — 17/142 commands fail; 2 CI-only arms skipped, compile tier explicitly skipped. A clean detached checkout at the same 2ea9a8be base reports the exact same 17 failing commands. No new failing gate command and no full-lint pass is claimed.
Full WASI guest-component execution has not been rerun locally; the tests verify the previously failing preparation step, not later component behavior.
Checklist
CI-only script/test change, no workspace version bump, crate/API change, changelog requirement or CHANGELOG.md edit.
No skipped component phase or weakened acceptance assertion.
Summary by CodeRabbit
Bug Fixes
Corrected Rust host dependency path resolution so prepared manifests point to the workspace’s perry-wasi crate.
Tests
Added coverage for valid and invalid dependency paths, including checks that source manifests remain unchanged.
No actionable comments were generated in the recent review.
Walkthrough
The Rust-host manifest preparation now matches a four-level relative dependency path instead of a six-level path. Tests check the resolved workspace crate path, preservation of the fixture, and rejection of an unexpected dependency path.
Changes: Rust-host manifest path
Layer / File(s)
Summary
Correct and verify the manifest dependency path scripts/component_guest_acceptance.py, tests/tooling/infrastructure/test_wasi_host_qualification.py
The helper now matches the four-level relative path. Tests check the resolved workspace crate path, confirm that the fixture remains unchanged, and verify that an unexpected dependency path raises an AssertionError.
This restores the WASI component job's manifest preparation so it matches the relocated fixture's dependency path. The change affects CI scripts and tests only, and no merge-blocking risk remains.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title "fix(ci): resolve relocated WASI component fixture dependency" matches the main change. The script now expects the relocated fixture's dependency path (four parent traversals instead of six)…
Description check
The description follows the repository template's main sections: Summary, Changes, Related issue, Test plan, and Checklist. The Summary explains the failure and the fix. Changes lists both files. Rela…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "fix(ci): resolve relocated WASI component fixture dependency" matches the main change. The script now expects the relocated fixture's dependency path (four parent traversals instead of six), and the new tests cover that path. It follows the repository's conventional prefix style and names the affected area without vague terms.
Full details: Description check
Explanation
The description follows the repository template's main sections: Summary, Changes, Related issue, Test plan, and Checklist. The Summary explains the failure and the fix. Changes lists both files. Related issue cites #14919 and the CI job, and it names the independent blockers #14928 and #14929. The Test plan gives concrete commands and results, and it states which checks were not run. The Checklist confirms no version bump or CHANGELOG edit. The template's Screenshots section is optional and absent. One point is weak: the template asks for a Changes list with file paths, which is present. The description does not repeat the no-version-bump and no-CHANGELOG reminders in the template comment, but the checklist covers them.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wasi-componentsbuilds its WASI runtime and then stops inprepare_rust_host_manifestwithAssertionError: Rust host path changed: crates/perry-wasi. The relocated fixture's manifest points six directories up to the workspace, while the preparation script still searches for the old four-directory path. Match the actual source manifest so the copied host keeps using the workspace's WASI provider.Changes
scripts/component_guest_acceptance.py: update the expected in-tree dependency path; preserve the exact-one-match assertion.tests/tooling/infrastructure/test_wasi_host_qualification.py: copy the real fixture to an arbitrary temporary directory and assert that only its dependency path becomes absolute. Also assert that a missing expected dependency still rejects the manifest without changing it.Related issue
CI investigation in #14919. The observed failure is in this WASI component job. No existing open PR covers this fixture-preparation failure.
Independent blockers: #14928 fixes e2e scope selection; #14929 fixes the compiler cache-input audit. Neither unrelated change is bundled here.
Test plan
python3 tests/tooling/infrastructure/test_wasi_host_qualification.py -vwith the fix: 8 passed.python3 tests/tooling/infrastructure/test_wasi_release.py: 19 passed.python3 scripts/check_test_registration.py.git diff --check.BASE_SHA=upstream/main CARGO_NET_OFFLINE=true SKIP_COMPILE_GATES=1 bash scripts/run_lint_gates.sh— 17/142 commands fail; 2 CI-only arms skipped, compile tier explicitly skipped. A clean detached checkout at the same2ea9a8bebase reports the exact same 17 failing commands. No new failing gate command and no full-lint pass is claimed.Checklist
CHANGELOG.mdedit.Summary by CodeRabbit
perry-wasicrate.