[Vanilla Fix] Correct sidebar radar horizontal offset for both styles

[Super-StarX]

What kind of change is this?

• New feature, vanilla bugfix or enhancement of a released feature - changelog, docs and credits entries are needed.
• Improvement to a new (unreleased) feature - docs and credits entries are needed; no changelog entry (Skip Changelog).
• Bugfix to a new (unreleased) feature - credits entry is needed; no changelog or docs entries (Skip Changelog, Skip Docs).
• Bugfix to an old (released) feature - changelog and credits entries are needed; no docs entry (Skip Docs).
• Completely minor change (e.g. a typo fix) - no entries are needed (Skip Changelog, Skip Docs, Skip Credits).

Description

Vanilla initializes the sidebar radar X origin at 16. The visible aperture starts at 13 for the Allied/GDI sidebar and 14 for the Soviet/NOD sidebar, so the radar content, its input rectangle, and the view rectangle are offset by 3 and 2 pixels respectively.

This PR corrects RadarClass::RadarX after the Allied and Soviet sidebar branches converge, using the existing isNODSidebar state derived from Sidebar.GDIPositions. The fix is enabled by default and can be disabled with:

[AudioVisual]
UseSidebarRadarOffsetFix=no

The before/after comparison was captured on the map Super Big Trouble (超级大麻烦).

Before

After

Notes

• The required YRpp definition is provided by Name RadarClass radar X origin YRpp#84; the submodule points to that branch so CI can resolve it.
• scripts\\build_debug.bat passes.

[github-actions]

Nightly build for this pull request:

• compiled-dll-8cab2df97e14c6663e45664916896a9e7d0b875e.zip
  These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

[NetsuNegi]

LGTM

[DeathFishAtEase]

Before:

After:

[DeathFishAtEase]

[Test] (In the latest Nightly Build)

Default behavior

• By default, the map frames of both ALL and SOV are aligned to the radar map centers of their corresponding sides (correspondingly, the map frames of the two sides differ by 1 pixel).

Sidebar.RadarOffsetFix

• For mods that have previously fixed the misalignment of radar map centers, those sides with Sidebar.GDIPositions=false can also manually set an offset value via Sidebar.RadarOffsetFix, thereby fixing the map frame out-of-bounds issue while maintaining consistency with the map frame position of the ALL side.