Repository navigation
Refused cursors that point away from Microsoft's services - #44
Merged
Merged
Conversation
stream() and delta() called a saved cursor with the user's token wherever it pointed, so a forged one could send that token to another server. They now raise ValueError before making any request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stream()anddelta()called a saved cursor with the user's token, wherever it pointed. If an app accepted cursors from outside, a forged one could send that token to another server.What changed
stream()anddelta()raiseValueErrorbefore making any request if a cursor doesn't point to the expected service.delta(): the cursor must use the same scheme and host as the client'sbase.chatsandmessages: the cursor must be HTTPS, on the region's chat service host or under.teams.microsoft.com.docs/caching.mdtells APIs that accept cursors from outside to also encrypt or sign them, and to check they belong to that user. This fix limits where a cursor can point, not whose it is.Links Microsoft returns during a run are still followed as before.
Testing
delta()resumed too, and forged cursors were refused with no failures.