Skip to content

Fixed chat_members when Graph throttles the members route - #47

Merged
PianoNic merged 1 commit into
mainfrom
fix/chat-members
Nov 4, 2026
Merged

PianoNic merged 1 commit into
mainfrom
fix/chat-members

Conversation

@PianoNic

@PianoNic PianoNic commented Nov 3, 2026

Copy link
Copy Markdown
Owner

Part of #46.

chat_members() used chats/{id}/members, which Graph kept answering with 429 on the tested account. It now reads the members through chats/{id}?$expand=members, which worked every time on the same chats.

Testing

  • 186 tests pass, including new ones for this. Ruff and mypy are clean.
  • On a real tenant, chat_members() returned members for all 47 chats it could list: 27 1:1, 14 group and 6 meeting. The largest had 22 members, the median time was 50-63 ms by chat type, and every member had a userId.
  • Each member has @odata.type, id, userId, displayName, email, roles, tenantId and visibleHistoryStartDateTime.

Not tested: chats with many more members. If Graph limits how many members $expand returns, very large chats could come back incomplete. I couldn't compare against the old route on these chats, because it was refusing requests.

The other items in #46 stay open.

It now reads members through chats/{id}?$expand=members, which worked on
every chat tested, while chats/{id}/members kept answering 429.
@PianoNic PianoNic added the bug Something isn't working label Nov 3, 2026
@PianoNic
PianoNic merged commit ba2937c into main Nov 4, 2026
3 checks passed
@PianoNic
PianoNic deleted the fix/chat-members branch November 6, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant