Repository navigation
Fixed chat_members when Graph throttles the members route - #47
Merged
Merged
Conversation
It now reads members through chats/{id}?$expand=members, which worked on
every chat tested, while chats/{id}/members kept answering 429.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #46.
chat_members()usedchats/{id}/members, which Graph kept answering with 429 on the tested account. It now reads the members throughchats/{id}?$expand=members, which worked every time on the same chats.Testing
chat_members()returned members for all 47 chats it could list: 27 1:1, 14 group and 6 meeting. The largest had 22 members, the median time was 50-63 ms by chat type, and every member had auserId.@odata.type,id,userId,displayName,email,roles,tenantIdandvisibleHistoryStartDateTime.Not tested: chats with many more members. If Graph limits how many members
$expandreturns, very large chats could come back incomplete. I couldn't compare against the old route on these chats, because it was refusing requests.The other items in #46 stay open.