Repository navigation
listen() renews its Teams session instead of ending the feed - #49
Merged
Merged
Conversation
With reconnect=False the feed ended about 75 minutes in, when the session token was about to expire. Renewal is planned, not a failure, so it now reconnects straight away in both modes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
listen()used to end the feed when Teams' session token was about to expire, about 75 minutes in, if it was started withreconnect=False. A planned renewal isn't a failure, so it now signs in again and reconnects straight away in both modes, without backing off, and yieldsconnectedagain.Testing
reconnect=False. Ruff and mypy are clean.connected, asdocs/live.mdsays.reconnect=Falseended after about 75 minutes.Not tested: a natural expiry on a long-running stream after this change. The live runs made the session expire early instead.