Skip to content

Keep slide 12's still until the tracker matches it - #108

Merged
MaxGhenis merged 1 commit into
mainfrom
appam-rebuild-8
Nov 5, 2026
Merged

MaxGhenis merged 1 commit into
mainfrom
appam-rebuild-8

Conversation

@MaxGhenis

Copy link
Copy Markdown
Contributor

The review of #106 caught production's slide 12 showing the tracker's fallback counts: 64 total programs, 56 complete, 2 partial and 6 in progress, under "Coverage reflects the bundled fallback registry." The notes, the alt text and the ledger say 109, 87, 18 and 4.

The tracker's first HTML prints those fallback counts before its data arrives, and the frame's check looked only for "Total programs". Now the frame shows only when:

  • the page prints the still's snapshot line, "Coverage reflects policyengine-us 2.72.3";
  • the page's fonts have loaded;
  • the slide is showing, because a hidden frame starts no font loads.

The still stays otherwise, including if the tracker moves to another snapshot, so the frame and the deck's counts can't disagree. trackerAgrees has tests for the fallback text, another snapshot, an empty or unreadable page, and fonts still loading.

A branch preview can't read the frame, so it still shows the frame on load. Audiences see production, where the check runs. I test it there by serving the preview from production's origin.

🤖 Generated with Claude Code

The tracker's first HTML prints fallback counts (64 total programs) before its
data arrives, and the frame's check looked only for "Total programs", so the
frame could cover the still with those counts. The check now requires the
still's snapshot line and loaded fonts, and it runs only while the slide shows,
because a hidden frame starts no font loads.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
policyengine-slides Ready Ready Preview Nov 5, 2026 4:26pm UTC

Request Review

@MaxGhenis
MaxGhenis merged commit 7954cfe into main Nov 5, 2026
5 checks passed
@MaxGhenis

Copy link
Copy Markdown
Contributor Author

Merged at ace9772 as 7954cfe at 16:28:06Z, because production could show the tracker's fallback counts during Max's talk. No independent review of this diff ran before the merge. The deck session read the diff and asked for the merge, and the in-session review that found the bug continues on the delta.

What passed at the head before merging:

  • gh pr checks exit 0 and a clean merge state.
  • projector-sweep.mjs at 1440×810 and 1280×720: no findings.
  • frame-check2.mjs in Chromium, with the preview served from production's origin: a 100 ms sampler on the talk's path and on a direct load of ?slide=13 caught the frame showing with fallback text 0 times, and with "Coverage reflects policyengine-us 2.72.3" every time it showed. Arrows moved the deck with and without a click in the frame.

Evidence for the bug: curl of /us/model/rules/coverage returns first HTML with "Coverage reflects the bundled fallback registry." and 64 total programs, and the client fetch replaces it. A production capture at about 16:19Z showed the frame over the still with those counts.

🤖 Generated with Claude Code

@MaxGhenis
MaxGhenis deleted the appam-rebuild-8 branch November 7, 2026 16:52

This branch was successfully deployed

1 active deployment
Preview – policyengine-slides — ace97722 Deployed Nov 5, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant