Repository navigation
Keep slide 12's still until the tracker matches it - #108
Merged
Merged
Conversation
The tracker's first HTML prints fallback counts (64 total programs) before its data arrives, and the frame's check looked only for "Total programs", so the frame could cover the still with those counts. The check now requires the still's snapshot line and loaded fonts, and it runs only while the slide shows, because a hidden frame starts no font loads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Merged at ace9772 as 7954cfe at 16:28:06Z, because production could show the tracker's fallback counts during Max's talk. No independent review of this diff ran before the merge. The deck session read the diff and asked for the merge, and the in-session review that found the bug continues on the delta. What passed at the head before merging:
Evidence for the bug: 🤖 Generated with Claude Code |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The review of #106 caught production's slide 12 showing the tracker's fallback counts: 64 total programs, 56 complete, 2 partial and 6 in progress, under "Coverage reflects the bundled fallback registry." The notes, the alt text and the ledger say 109, 87, 18 and 4.
The tracker's first HTML prints those fallback counts before its data arrives, and the frame's check looked only for "Total programs". Now the frame shows only when:
The still stays otherwise, including if the tracker moves to another snapshot, so the frame and the deck's counts can't disagree.
trackerAgreeshas tests for the fallback text, another snapshot, an empty or unreadable page, and fonts still loading.A branch preview can't read the frame, so it still shows the frame on load. Audiences see production, where the check runs. I test it there by serving the preview from production's origin.
🤖 Generated with Claude Code