Repository navigation
Model Hawaii's claim of right deduction and credit (section 1341 as operative in Hawaii from 2022) - #10200
Merged
Conversation
G.S. 105-153.5(a)(2)d, added by S.L. 2016-5 for 2014 and later, lets North Carolina itemizers deduct repayments of income included in AGI in an earlier year under a claim of right (Form D-400 Schedule A line 8). Repayments above $3,000 are deductible in full; smaller ones are reduced by 2% of federal AGI less other miscellaneous itemized deductions, which the 2016 and 2025 NCDOR worksheets both reproduce. PE had no input for these repayments, so it adds claim_of_right_repayment (person level; only the head's and spouse's count) and moves North Carolina's uncapped itemized items into a parameter list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…C taxed Review r1 (subfleet 20261009-090558-nc-itemized-review): - S.L. 2026-31 section 1.8 rewrites G.S. 105-153.5(a)(2)d for taxable years beginning on or after January 1, 2026: the repaid amount must have been included in AGI "as modified in G.S. 105-153.5 and G.S. 105-153.6" in the earlier year. New person input nc_claim_of_right_repayment_excluded_from_income (the part NC deducted when received, such as repaid Social Security) and a dated parameter apply it. - Count only the head's and spouse's other miscellaneous expenses against the pre-2018 floor; a dependent's are on the dependent's return. - The property grid now varies property taxes (so the $20,000 cap binds) and adds a 2026 grid for the excluded part. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…h Carolina's 1341(a)(5) bar and G.S. 105-266.2 payment (WIP) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…es that exclude them (AZ, KS, WI, MO, OR, VA); property tests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…fragment Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…to keep it at two seconds Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…urn-level prior-year inputs, California and Montana flows - The branches that fix the claim of right method start from inputs only, and the itemization branches settle the method in the parent first, so a tax liability calculated before the method is known cannot leak into them. - Ties are compared to the cent, so a one-cent difference picks the credit. - The prior-year federal decrease and NC increase are return-level inputs defined on chapter 1 and Article 4 tax. - California leaves out the federal deduction (Schedule CA Part II line 16); Montana deducts it through 2023 (Form 2 itemized line 18). - Section 67(g) is now 67(h); document the Arizona and NC coverage limits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review r2 found that with itemization branching off, tax_liability_if_not_itemizing used the parent's method when calculated first but chose its own after income_tax. The itemizing branches now take the method as an input. A branch keeps its parent's cache when an override equals the value the parent already holds, so ordinary simulations still share it. Adds the review's Texas household as an order test under both itemization settings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… branches only when someone qualifies Review r3 showed that keeping a parent's cache when an override equals the parent's current value can reuse tax calculated before another input changed. Branches again drop inherited values whenever the parent knows an overridden variable. The itemizing branches add the claim of right method as an override only when some tax unit repays more than $3,000, so simulations without a qualifying repayment keep sharing the parent's cache. Adds the review's stale-parent sequence as a test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…th use tax Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ate property test Under the federal credit method, section 1341(b)(3) keeps the repayment out of every state that only follows the federal deduction, so their tax must not change. States with their own claim of right relief may lower tax under either method. The test now reads which states have their own rule from the model's variable names (<state>_claim_of_right_...), so a state PR adds its variables without editing this list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…pending Max's ruling) Act 56 (SLH 2023) made section 1341 operative in Hawaii for taxable years beginning after December 31, 2021, and Act 35 (SLH 2026) keeps it. Hawaii tax is the lesser of the tax with a deduction for a repayment over $3,000 and the tax without it less the decrease in prior-year Hawaii tax (Form N-364), which is a refundable credit (Schedule CR line 9). Hawaii makes its own comparison with branches on hi_income_tax, independent of the federal method. Before 2022, and for repayments of $3,000 or less, a repayment is a miscellaneous itemized deduction above 2% of Hawaii AGI while Hawaii allows those (HRS 235-2.4(b); Act 35 ends that from 2026). For 2022-2025 this follows the statute: section 67(b)(9) keeps the section 1341 deduction outside the 2% floor. The 2022-2025 N-11 instructions list the items the other way round, and Form N-364 adds the repayment to Hawaii AGI when the federal deduction was taken; those readings go to Max. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Over a grid for 2021, 2025 and 2026, against simulations that fix Hawaii's method as an input: Hawaii tax is the lesser of the two methods (ties to the deduction) and the branches equal those simulations; the deduction and credit are all or nothing and never both, with no credit before 2022; Hawaii tax does not depend on the federal method, never rises with a repayment, and never rises as the repayment or the prior-year decrease grows. Four single-line mutants (ties to the credit, a floor on the section 1341 deduction, the credit left out of the refundable list, section 1341 operative from 2021) each fail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…eral credit Reviews of #10195, #10196 and #10198 found that reading own-rule states from variable names weakened the cross-state test: North Carolina and Montana lost their exact check, nothing asserted that a state's own relief actually lowered its tax, and any future <state>_claim_of_right_ input would exempt a state. Now an explicit, sourced map names each state whose relief applies under the federal credit method and the variable that carries it. Under that method each listed state whose variable is in the model must lower the household's tax by more than $1, and every other state's tax must not change. The same commit is on every state branch, so they still merge in any order. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 13, 2026
Merged
Merged
…ouncement 2026-06 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Resolves the add/add conflicts with #10028's squash (557b539) by keeping this branch's 26 U.S.C. 1341(a)(5) bar on the North Carolina deduction, its added NC cases and the method fixture in the NC property grid, and keeps both sides' Arizona itemized deduction cases. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaxGhenis
marked this pull request as ready for review
October 13, 2026 12:09
…rom 2024 From 2024 Montana Form 2 line 2 takes the federal itemized deductions (2024 instructions, Worksheet A line 1: Form 1040 line 12), which include Schedule A line 16. The miscellaneous list was empty from 2024, so a Montana itemizer lost the federal claim of right deduction. Review r5b (P3-1) found it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…anch Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Hand-off to the US + core hub (Hawaii; state claim of right lane, session local_d0c92ac9).
|
Conflicts resolved: - Wisconsin itemized deduction credit: keep main's explicit Schedule 1 component list (#10311) and add claim_of_right_deduction to it, so the section 1341 repayment stays in the credit base as this PR intends under Wis. Stat. 71.07(5)(a)6-7. - Alabama and Wisconsin YAML tests: keep both sides' cases. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… 2025 The 2024 Form 2 Worksheet A reduces the federal deduction by the capped state-income-tax addback before line 3's zero floor. The 2025 form stops adjusting line 2 and reports the addback on Schedule I line 4, a Montana addition after the floor, as MCA 15-30-2120(1) treats the (2)(j) item alongside the other additions. A new boolean parameter is true in 2024 and false from 2025 (2026 follows the 2025 form by convention), and both mt_taxable_income_joint and mt_federal_deductions read it. Adds 2025 and 2026 YAML witnesses (the review's AGI 10,000 / itemized 20,000 household gives 4,250 in 2025), keeps the 2024 pre-floor witnesses, limits the property test to 2024, and points the misc_deductions comment at mt_taxable_income_joint, which is what reads the federal base. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ala. Admin. Code r. 810-3-15-.20(1)(d)2 subtracts all credits shown as payments on the federal return, and its current text dates from a 2010 amendment, so it governs every year the parameter covers, not only 2021 on. The legacy pre-2021 list (total AOC, no section 1341 credit or net PTC) is dropped, and the 2020 case that pinned it now expects 5,000 - 1,000 - 1,500 - 1,000 - 750 = 750. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
main's backlog still described the code before this PR: AL, MO and WI as following the worksheets and OR as unknown. The head follows the statute or regulation in all four, so set pe_us.follows to statute and state to ruled, replace the notes that said a model change was still needed, start AL's years in 2015 (the corrected credit list now applies from the parameter's first year), and cite ORS 316.685(1)(b), the EITC-only disregard the OR code follows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The 2017 Montana Form 2 with Legal References now 404s at its original address; cite the Wayback Machine copy of 2024-01-07, whose PDF p. 6 Schedule III lines 25, 26 and 28 the reviewer confirmed. Drop the "2023 HB 109" reference: its URL mixes HB0199 and HB0109, returns 404, and what it was meant to support could not be confirmed; MCA 15-30-2120 is already cited for the deduction. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both cases set claim_of_right_credit as an input that neither formula reads, so they only checked that income_tax passes through. They now use the federal integration case 4 household (2025, $40,000 wages, $10,000 repayment, $2,200 prior-year decrease), where the credit method wins and flows through income_tax: 2,671.50 - 2,200 = 471.50. Missouri deducts 25% x 471.50 = 117.875 and Oregon subtracts 471.50. Adding the credit back in either formula fails its case. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
main's #10186 made the 2020 itemization choice compare two branches with different AGI (the 2020 above-the-line charitable deduction), and no invariant in this file ran on that path. Add 2020 to YEARS (last, so the tests that read YEARS[0] and YEARS[1] keep 2025 and 2026) and run the calculation-order test in 2020 as well. Every existing assertion is kept; all 58 tests pass. Locally the file went from 182 s to 220 s and its peak RSS from 3.2 GB to 3.5 GB. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The claim-of-right fragment described the Montana work as repayment treatment, but from 2024 every Montana filer's taxable income now starts from the federal base (all six mt_taxable_income_joint cases changed), and every Alabama AOC claimant now subtracts only the refundable part. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…6 case The old 2025 case supplied a positive QBI deduction at a binding floor, which the model can't produce before 2026. From 2026 the 199A(i) $400 minimum can exceed taxable income, so a derived household now pins the order: MCA 15-30-2101(22) and 15-30-2120(2)(i) add the deduction back to federal taxable income before Form 2's line 7 floor, giving 0, not 400. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LwQq6JfLQkf8A2aNSw51a4
Once #10093 nets the premium tax credit in Oregon's subtraction, this household's modeled credit would zero the subtraction. Pinning it keeps the case isolating the section 1341 credit at 471.50. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LwQq6JfLQkf8A2aNSw51a4
YEARS is (2024,), so the Schedule 1-A draw and the year >= 2025 branches never ran; YAML cases cover 2025 and 2026. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LwQq6JfLQkf8A2aNSw51a4
mt_taxable_income_joint computes its own deduction term from taxable_income_deductions, which also holds the QBI deduction and the Schedule 1-A deductions, so the two differ (e.g. 15,750 against 21,750 in the 2025 tip case) and the formula can't read this variable. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LwQq6JfLQkf8A2aNSw51a4
The code applies the regulation's list from 2015, but worksheets before 2018 went unchecked, so the item can't claim a conflict for 2015-2017. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LwQq6JfLQkf8A2aNSw51a4
The comment argued from federal taxable income having no floor, which would also remove the line 3 floor the code keeps for Montana's other additions. The order follows the form: line 2 leaves the QBI deduction out, and line 3 floors line 1 minus line 2 at zero. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LwQq6K4hbmpvP2YevFmELw
Main removed gov.household.household_refundable_credits and gov.household.household_tax_before_refundable_credits, which no formula read after it dropped the abolish-tax structural reforms. This branch had added North Carolina to both. The merge keeps the removal; this branch's North Carolina entries stay in gov.household.household_refundable_state_credits and the gov.states.household lists. Main's new North Carolina use tax case under the payroll tax repeal enters nc_income_tax, which this branch's state list no longer reads: the list now counts North Carolina tax before refundable credits. The case now enters nc_income_tax_before_refundable_credits, and its totals stay at 1,020. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#10094 also adds an entry to source_conflicts/candidates.yaml. Git merges the two cleanly, and the merged register keeps unique ids. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The shared property test keeps main's two-state deduction list and its Alabama, Missouri and Oregon case, and this branch's relief-state map. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Main carries the federal section 1341 work, so its changelog fragments leave this branch. The Oregon files and the candidate list follow main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10200 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 9 +8
Lines 37 128 +91
Branches 0 2 +2
=========================================
+ Hits 37 128 +91
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The model has other miscellaneous expenses; Hawaii's itemized list omits them. The backlog item now names the file that omits the deduction under the credit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Merging at
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
From 2022 Hawaii applies 26 U.S.C. 1341 on its own. For an eligible repayment over $3,000, Hawaii tax equals the lesser of the tax with a deduction for the repayment and the tax without it less the decrease in prior-year Hawaii tax. Hawaii pays that decrease as a refundable credit. Before 2022, and for repayments of $3,000 or less, a repayment counts as a miscellaneous itemized deduction above 2% of Hawaii AGI while Hawaii allows those (through 2025). PolicyEngine had none of this, so a repayment changed nothing in Hawaii. This PR adds it.
hi_claim_of_right_prior_year_tax_decrease(tax unit; Form N-364 lines 4–6) andhi_claim_of_right_repayment_excluded_from_income(person; income Hawaii didn't tax when received).hi_claim_of_right_repayment,hi_claim_of_right_section_1341_eligible, andhi_claim_of_right_credit_applies, which compares final Hawaii income tax in two override branches (hi_income_tax_if_claiming_claim_of_right_credit,..._deduction), as the federal rule does and as the model already does for Virginia's and Delaware's EITC.hi_claim_of_right_deductionjoins Hawaii's itemized sources, andhi_claim_of_right_creditjoins Hawaii's refundable credits from 2022.gov.states.hi.tax.income.claim_of_right.section_1341_operative(from 2022) andgov.states.hi.tax.income.deductions.itemized.miscellaneous_deductions_allowed(through 2025).The law
How the model reads the sources
The 2% floor, 2022–2025
The model follows the statute. Section 67(b)(9), operative through HRS 235-2.4(b), keeps the section 1341 deduction over $3,000 outside the 2% floor, and the smaller repayment stays in the floored pool. The 2022 and 2025 N-11 lists put the over-$3,000 deduction under expenses subject to the floor and the $3,000-or-less deduction outside it, the reverse of the federal categories.
Two source points suggest the N-11 categories transposed the federal ones. HRS 235-2.5(a) makes a reference from an operative federal provision to an inoperative one inoperative too, so section 67(b)(9)'s reference to section 1341 couldn't exempt the larger repayment before section 1341 became operative. Act 56 removes that reason from 2022. And the 2017 federal Schedule A instructions put repayments of $3,000 or less on line 23 within the floor and larger repayments on line 28 outside it. Both Hawaii entries point to the repayment discussion in 2017 Publication 525, which sends wage repayments back to Schedule A and its instructions.
From 2026, Act 35 disallows miscellaneous deductions, so the $3,000-or-less repayment gets nothing, and the over-$3,000 deduction continues outside that class.
N-364 line 2's AGI add-back
N-364 directs a filer who took the federal deduction to add the repayment to Hawaii AGI, reasoning that the deduction entered federal taxable income. But N-11 line 7 starts from federal AGI, and a Schedule A deduction doesn't reduce that amount. PolicyEngine's Hawaii itemized list also leaves out the federal claim of right deduction. For the itemized repayments this model covers, an AGI add-back would add income no one subtracted, so the model keeps the Hawaii deduction at zero under section 1341(a)(5) and adds nothing to AGI. An add-back could matter for a repayment deducted in arriving at AGI, but
claim_of_right_repaymentexcludes those.Credit ordering with the existing EITC rule
HRS 235-91.5 requires filers to use refundable credits before nonrefundable credits. The 2022 N-11 instructions implement this by subtracting refundable credits at line 34 and capping nonrefundable credits at the remaining adjusted tax liability. The model's Hawaii income tax follows that order, and this PR's credit enters it.
For the credits the model has, this interaction affects only 2022: the claim of right credit begins then, and Hawaii's EITC stays nonrefundable through 2022 and turns refundable from 2023. The method comparison reads final
hi_income_tax, so it includes any EITC the credit displaces.For a 2022 head of household with one child aged 5, no TANF receipt, a $10,000 repayment and a $600 prior-year Hawaii decrease:
At $22,500, the fixed credit branch starts with $728 of tax and subtracts $710 of refundable credits: the $110 food/excise credit plus the $600 claim of right credit. That leaves $18 of adjusted tax liability, which caps the EITC at $18 and takes final tax to zero. Without the repayment, the EITC uses the full $618 remaining after the food/excise credit and again leaves zero tax. The deduction branch also ends at zero, so the strict comparison keeps the deduction.
The credit can still produce a section 1341(b)(1) refund. A 2025 single filer with $40,000 of wages, a $10,000 repayment and a $3,000 Hawaii decrease has $1,570.21 of tax before this credit and no other Hawaii credit. The credit wins, and
hi_income_taxcomes to −$1,429.79.Design notes
total_misc_deductions(unreimbursed employee expenses and tax preparation fees). Hawaii's existing itemized limitation (hi_reduced_itemized_deductions) reduces the repayment deduction as it does other nonexempt itemized deductions.Illinois and Ohio (#10195), Indiana, Massachusetts and West Virginia (#10196), New Jersey (#10198) and Arkansas (#10203) use the same federal input in their own PRs.
Not modeled:
claim_of_right_repaymentexcludes them.Household examples (2025, single, age 40)
Tests
Under
gov/states/hi/tax/income/claim_of_right/:hi_claim_of_right_credit_applies.yaml(4 cases) andhi_claim_of_right_deduction.yaml(6 cases) cover each fixed Hawaii method, the $3,000 threshold, the 2% floor, 2021 before section 1341 became operative, and 2026 after miscellaneous deductions end. They also cover income Hawaii never taxed, a joint return counting both spouses, each chosen method and another state. The two chosen-method cases also asserthi_income_tax: $1,529.86 and $4,124.26.hi_income_tax.yaml(5 cases) pins the 2022 credit ordering above, the $22,500 no-repayment baseline and deduction tie, the fixed-credit branch's displaced EITC, and the 2025 refund.tests/unit/test_hi_claim_of_right_properties.pyruns 11 tests over a 108-return grid for each of 2021, 2025 and 2026 (repayment × Hawaii decrease × wages × charity). It needs Python because its checks compare independent branch simulations.Invariants
Letting ties go to the credit, putting a 2% floor on the section 1341 deduction, leaving the credit out of the refundable list, or making section 1341 operative from 2021 each fails the property suite.
test_claim_of_right_section_1341_properties.pynow holds an explicit, sourced map of the states whose own relief applies under the federal credit method. Each listed state whose variable exists must lower the household's tax by more than $1, and every other state stays unchanged, apart from the three that deduct federal tax. #10195, #10196, #10198 and #10203 carry the identical file, so they merge in any order.Cost
At an earlier head, CI run 38545546945 took about 10 s for the property file (3.76 s of fixture setup and 6.30 s of teardown). The Rest shard-1
remaininggroup took 14:30 wall time with a 7.82 GB peak on a 16 GB runner. The fixture makes 15 simulations of 108 returns and frees them at teardown.Microsimulation impact
We estimate no change in 2025. No record in the default dataset carries
claim_of_right_repayment, and the Hawaii deduction and credit need a repayment, so no record changes inhi_income_tax,state_income_tax,income_taxorhousehold_net_income.Axiom
axiom: TheAxiomFoundation/rulespec-us#1796 queued
rulespec-us still pins Hawaii's conformity at December 31, 2024 and defers itemized deductions (
us-hi/policies/income_tax/resident_core_liability_pipeline.yaml). The pinned corpus contains the section 1341 exception.impact: none in 2025; no record in the default dataset carries
claim_of_right_repayment🤖 Generated with Claude Code