Repository navigation
fix: plugin header minimums match the framework - #3
Merged
Merged
Conversation
… WordPress it runs on
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1 set the header to
Requires PHP: 8.4andRequires at least: 7.1(a new project's stack). Butmake:plugindownloads the latest tag whatever the site runs, and WordPress refuses to activate a plugin whose header asks for more than the site has. So on a supported site — the framework requires PHP^8.3, and this file keeps a code path for 13.4 sites on WordPress 6.x — the generated plugin could not be activated.Requires PHP: 8.3(the framework's minimum)Requires at least: 6.0(as before docs: refresh the README #1; the plugin uses no newer WordPress API)Tested up to: 7.1keptphp bin/tests/run.php: passes.