Repository navigation
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Owner
Author
|
@claude The theme toggle has an aria-label but no tooltip. Add a title with the same text ("Switch to dark theme" / "Switch to light theme") so mouse users see what it does on hover, and cover it in the toggle's tests. |
|
Claude finished @Prodyte's task in 1m 58s —— View job Theme toggle tooltip added
The toggle in The full suite passed: 428 passed, 1 skipped. Pushed as
|
…s the aria-label, and the toggle's tests check both Co-authored-by: Pawan <31545438+Prodyte@users.noreply.github.com> Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1
Built by the
shipworkflow: dev, reviewer and qa agents in GitHub Actions. This PR was opened by hand after the run, because the workflow wasn't allowed to create PRs yet (now fixed).nihongo.theme, the same setting as Settings → Theme. Only Settings returns to System.Appholds the theme, so the Settings dropdown follows the toggle.button:focus-visibleoutline applies.Tests: 428 passed, 1 skipped.
Run log: https://github.com/Prodyte/nihongo/actions/runs/38344650864