Repository navigation
Add Quick light/dark theme toggle in the app bar - #4
Open
github-actions[bot] wants to merge 1 commit into
Open
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…dark theme in one tap Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3
Ship summary: quick light/dark theme toggle
Assumptions
icon-btn/account-btnclasses for focus ring and 44px tap target.key={theme}) so its select stays in sync; any sync message shown there is lost.Summary
Sun/moon button in the phone top bar (next to account) and in the wide-screen nav, hidden in full-screen lessons. Flips the displayed theme (System resolves via OS preference), saves to
nihongo.themelike Settings. Committed, not pushed.Run log: https://github.com/Prodyte/nihongo/actions/runs/38523062239