Skip to content

ci: pin actions to SHAs, drop caches from publish, enforce with zizmor [PRV-7340] - #18

Merged
ynahmany merged 2 commits into
masterfrom
PRV-7340-pin-actions
Oct 19, 2026
Merged

ynahmany merged 2 commits into
masterfrom
PRV-7340-pin-actions

Conversation

@ynahmany

@ynahmany ynahmany commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Makes the publish-workflow hardening stick for future changes.

What

  • Actions pinned to commit SHAs, version in a comment (actions/checkout@<sha> # v5.1.0). snyk/actions/node moves from @master to the v1.0.0 release SHA.
  • .github/dependabot.yml: weekly, one grouped PR for GitHub Actions updates, so the pins stay current. CI runs on each.
  • No cache in the publishing job: removed the yarn cache step and set package-manager-cache: false on setup-node, so a poisoned cache entry cannot reach the npm package (zizmor cache-poisoning).
  • New CI job Workflow security (zizmor): fails on any workflow finding (unpinned action, broad permissions, secrets: inherit, cache in a release job, …).
  • .github/zizmor.yml: disables only self-repository (a style hint to use $/ instead of ./ for this repo's own reusable workflow).

Verified locally

zizmor 1.31.1, offline and online: no findings (before: 9–10 high).

Same change in squiss-ts, price-extractor, promise-blocking-queue. Ticket: PRV-7340.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

ynahmany and others added 2 commits October 19, 2026 11:07
PRV-7340]

- Pin every action to a commit SHA (version in a comment); Dependabot
  keeps the pins current with a weekly grouped PR.
- No cache in the publishing job: setup-node package-manager-cache off
  and the yarn cache step removed, so a poisoned cache entry cannot
  reach the published package.
- New zizmor job in CI fails on any workflow security finding, so a
  later change cannot weaken the workflows unnoticed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zizmor (dependabot-cooldown) flags updates proposed the moment a
release lands; a hijacked action version is usually pulled within days.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ynahmany
ynahmany merged commit 4b87df2 into master Oct 19, 2026
8 checks passed
@ynahmany
ynahmany deleted the PRV-7340-pin-actions branch October 19, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant