Skip to content

ci: use the shared oss-workflows for CI and publish [PRV-8217] - #20

Merged
ynahmany merged 1 commit into
masterfrom
PRV-8217-shared-ci
Oct 20, 2026
Merged

ynahmany merged 1 commit into
masterfrom
PRV-8217-shared-ci

Conversation

@ynahmany

@ynahmany ynahmany commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Moves CI and publish to the shared public workflows (PruvoNet/oss-workflows v1, pinned by SHA). Proven end to end on loopback-component-flatstorage@1.2.2 (OIDC publish with provenance through the shared workflow).

  • ci.yml → ci-node.yml with this repo's package manager, Node/OS matrix and build/test/coverage commands, plus zizmor.yml.
  • publish.yml → runs ci.yml, then publish-npm.yml. Same file name, so the npm trusted publisher is unchanged.
  • Snyk step removed (PRV-7340 item 7: personal account; Dependabot alerts are on).
  • No code change, no release.

Check names change to ci / CI (<os>, <node>) and zizmor / Workflow security (zizmor). If classic branch protection still requires the old names, merge with the owner bypass; the PRV-8217 Terraform ruleset then requires the new names.

Ticket: PRV-8217.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Summary by CodeRabbit

  • Chores
    • Updated automated validation to run across Node.js 14, 16, 18, 20, 22, and 24.
    • Standardized build, test, coverage, security checks, and publishing workflows for more consistent project maintenance.
    • Strengthened workflow permissions and publishing authentication controls.
    • Publishing now occurs through the standardized release process after successful continuous integration checks.

ci.yml and publish.yml become thin callers of PruvoNet/oss-workflows
(pinned by SHA, v1); the build, test and coverage commands are kept.
The Snyk step is dropped (PRV-7340: it ran under a personal account;
Dependabot alerts cover dependency advisories). publish.yml keeps its
name, which the npm trusted publisher names. Proven on
loopback-component-flatstorage 1.2.2. No code change, no release.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: PruvoNet/coderabbit/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Team
  • Run ID: 3e9f6592-8ab2-440d-a6eb-c445390181a9
📥 Commits

Reviewing files that changed from the base of the PR and between 4b87df2 and e5426f0.

📒 Files selected for processing: 2
  • .github/workflows/ci.yml
  • .github/workflows/publish.yml

Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour.

📝 Walkthrough

The CI workflow replaces inline Node.js and zizmor jobs with reusable workflows. The publishing workflow delegates npm publishing to a reusable workflow after CI succeeds.

Changes: CI and publishing workflows

Layer / File(s) Summary
Reusable CI and security checks
.github/workflows/ci.yml
The workflow delegates Node.js CI across six versions and zizmor checks to reusable workflows. It sets top-level permissions to none and grants the jobs read-only contents access.
Reusable npm publishing
.github/workflows/publish.yml
The workflow delegates publishing to a pinned reusable workflow with Yarn and yarn build. It retains the CI dependency and OIDC/read permissions. The prior inline validation and publish steps are removed.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: regevbr

Merge Risk: ⚪ Minimal · up to e5426

The delegated CI checks and release safeguards are preserved; the PR is ready to merge after normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title uses the required Conventional Commits ci: prefix and clearly describes the move to shared workflows for CI and publishing.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@ynahmany
ynahmany merged commit d85a735 into master Oct 20, 2026
8 checks passed
@ynahmany
ynahmany deleted the PRV-8217-shared-ci branch October 20, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant