Repository navigation
Route MultiFS removal through the writable filesystem - #607
Open
Hugohong258 wants to merge 1 commit into
Open
Hugohong258 wants to merge 1 commit into
Hugohong258 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
remove()andremovedir()currently use the read lookup, so they can delete resources from a child added withwrite=False, including when no write filesystem is configured. Route both through_writable_required(), consistently with other modifying operations. A higher-priority read source is preserved; deletion acts on the configured writer, and a missing writer-side resource raisesResourceNotFound. Fixes #572.All six new regressions fail on the base. On Windows/Python 3.9.25, the complete MultiFS module passes 101 tests with 1 skip. Project-pinned Black 22.3, Flake8 3.7.9 with the configured plugins, and mypy 0.800 on the changed source pass. The full 57-file type check reports the same five diagnostics on unchanged upstream and both patched worktrees (four Windows-only
osmembers and one entry-point type). Existing pkg_resources deprecation warnings remain. The full project/platform matrix was not run.