Repository navigation
Document reserved characters in FS URL resources - #609
Open
Hugohong258 wants to merge 1 commit into
Open
Hugohong258 wants to merge 1 commit into
Hugohong258 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
An unescaped
!in an FS URL resource is parsed as the separator for anoptional path, which
open_fsignores. Document how to percent-encode it,and the query delimiter
?, when they are part of the resource. This alsoapplies to paths passed without an explicit protocol. Closes #562.
On Windows with Python 3.9.25, I verified that an OSFS URL with
!activeopens the parent directory while
%21activeopens the intended directory;the parser also distinguishes literal
?from%3F. The existing openertests passed (34 tests, with four existing
pkg_resourcesdeprecationwarnings). The Sphinx 3.5.4 HTML build completed with 90 warnings, including
missing static files, autodoc warnings and the existing contributing page's
missing title. The documentation environment required compatible older Jinja2
and Sphinx extension versions. No implementation code was changed.