Repository navigation
v1 STAR pipettes: tidy the Y profile and probe code - #1613
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem
The Y-speed and probing work of #1607, #1608, #1609 and #1611 left some loose ends:
_set_y_drive_profilessat under the Z section, many of the new calls didn't name their arguments, one comparison was split awkwardly across lines, the X search's docstring still described sending it without a channel, and one Y probe test still said "backs away".PR Content
No behaviour changes.
_set_y_drive_profilesmoves into the Y section, still above its callers.pipettes.py,simulator.pyand the tests.default_speed._unchecked_fw_probe_x_using_clld: thechannelline no longer describes a search withoutpn, which the required argument now rules out.test_y_probe_that_finds_nothing_backs_away_and_answers_nonebecomes…makes_its_post_detection_move_and_answers_none.🤖 Generated with Claude Code