Repository navigation
security: bound and validate NumPy headers - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.npyheader parsing to 1 MiB before decoding or evaluating the header.Security rationale
ModelHawk parses untrusted serialized model artifacts. Header lengths are attacker-controlled; rejecting oversized or malformed headers limits parser work and ensures malformed input produces a conservative finding rather than being silently accepted. The scanner still never deserializes pickle payloads.
Validation
CI should run the complete existing self-test on the supported Python matrix. No security gate is disabled or relaxed.