Skip to content

VacuumModes.GENTLE and VacuumModes.OFF share value 105 #999

Open

Description

@swastiktawate

In roborock/data/v1/v1_clean_modes.py, VacuumModes has the same value-alias problem that #990 fixes for WaterModes:

GENTLE = ("gentle", 105)
OFF = ("off", 105)

Two members sharing one value means lookups by value are ambiguous. Suggest applying the same display_name pattern from #990 here so each mode keeps a distinct value.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions