Skip to content

fix(mower): document error semantics and log unknown status codes - #1009

Merged
allenporter merged 1 commit into
mainfrom
codex/mower-status-followup
Nov 2, 2026
Merged

allenporter merged 1 commit into
mainfrom
codex/mower-status-followup

Conversation

@Lash-L

@Lash-L Lash-L commented Nov 1, 2026

Copy link
Copy Markdown
Collaborator

Follow up Allen's error-case and logging comments on #1002. Document and test that a missing or null error code stays None, while the protocol's zero (UNKNOWN) and unrecognized firmware codes remain MowerErrorCode.UNKNOWN. Cover dictionary/DPS inputs and serialization round trips without changing the wire meanings.

Log unrecognized mower enum values at debug level before using the existing fallback. Recognized values, including explicit UNKNOWN, and optional lookups stay silent. GPS redaction remains in the separate device-support work.

Validation:

  • Mower tests: 127 passed.
  • Full suite on Python 3.14: 2,038 passed, 53 xfailed, 11 deselected; 99 snapshots passed.
  • pre-commit run --all-files: all hooks passed, including Ruff, Mypy, and Codespell.

Copilot AI balanced review requested due to automatic review settings November 1, 2026 23:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@codecov

codecov Bot commented Nov 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
roborock/data/mower/mower_code_mappings.py 100.00% <100.00%> (ø)
roborock/data/mower/mower_containers.py 100.00% <100.00%> (ø)
tests/data/mower/test_mower_code_mappings.py 100.00% <100.00%> (ø)
tests/data/mower/test_mower_containers.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@allenporter
allenporter merged commit 8ee7d76 into main Nov 2, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants