Repository navigation
fix(mower): document error semantics and log unknown status codes - #1009
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
allenporter
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up Allen's error-case and logging comments on #1002. Document and test that a missing or null error code stays
None, while the protocol's zero (UNKNOWN) and unrecognized firmware codes remainMowerErrorCode.UNKNOWN. Cover dictionary/DPS inputs and serialization round trips without changing the wire meanings.Log unrecognized mower enum values at debug level before using the existing fallback. Recognized values, including explicit
UNKNOWN, and optional lookups stay silent. GPS redaction remains in the separate device-support work.Validation:
pre-commit run --all-files: all hooks passed, including Ruff, Mypy, and Codespell.