Repository navigation
Apply the #57 answer to numpy: commas on case-marked -ഉം pairs (2 places) - #59
Merged
Merged
Conversation
…airs Adisankar ruled on #57 (answer 1.2) that two items carrying a case ending as well as -ഉം always take a comma, as plain -ഉം pairs do. Two pairs on the reviewed numpy page were still bare: - line 840: `a`-യിലും, `b`-യിലും - line 902: speed-ന്റെയും, memory-യുടെയും Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
📖 HTML build - view preview (3a875d9) Translated pages in this PR: |
There was a problem hiding this comment.
🟢 Approval recommended
The two edits correctly and completely apply an established, codebase-verified comma convention with no missed pairs and no functional impact.
No open issues 🎉
What changed in this PR
This PR applies a confirmed Malayalam translation style decision (from issue #57, answer 1.2) to the already-published numpy lecture: it inserts a comma between two coordinated items that each carry a case ending plus -ഉം. It is a minimal typographic/style fix to the Malayalam translation with no code or functional changes, bringing the numpy page into line with the convention already used in matplotlib and python_by_example.
Changes:
- Line 840:
`a`-യിലും `b`-യിലും→`a`-യിലും, `b`-യിലും(added comma). - Line 902:
speed-ന്റെയും memory-യുടെയും→speed-ന്റെയും, memory-യുടെയും(added comma).
| File | Description |
|---|---|
| lectures/numpy.md | Adds a comma between two case-marked -ഉം items in two places (lines 840 and 902) to match the established "always a comma" convention. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@adisankarmt — thank you for the answers on #57. Your answer 1.2 (always a comma) applies to two places on the
numpypage that is already on the site, so this small PR brings them into line. Nothing else changes. It needs only a quick look from you: approve it if both read correctly, or tell us which to put back.From your answer 1.2: always a comma between case-marked
-ഉംitems`a`-യിലും `b`-യിലും`a`-യിലും, `b`-യിലുംspeed-ന്റെയും memory-യുടെയുംspeed-ന്റെയും, memory-യുടെയുംThese are the two pairs #57 mentioned, which you left without a comma in round 4. A search of the other reviewed pages found no more pairs of this kind.
For @mmcky: the search also found shapes the engine's comma repair must leave alone, and these are now its test cases: a pair with a further ending on the second item, such as
rows-ലും columns-ലുമായി(pandas, line 161, the editor's own round-5 text); verb pairs such asrepresent ചെയ്യാനും analyze ചെയ്യാനും; and single items that mean "all" or "any", such asഎല്ലാ plots-നെയും. The tool-side change is QuantEcon/action-translation#403.🤖 Generated with Claude Code