Repository navigation
chore: Remove test covered by summary fixture - #73
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 1144 1144
=========================================
Hits 1144 1144 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Existing fixtures cover the removed assertion and option combinations, with no unresolved issues identified.
No open issues 🎉
What changed in this PR
Removes a redundant summary test from Diffly’s test suite, relying on the existing no_common_non_pk_columns fixture for equivalent coverage.
Changes:
- Deletes
test_summary_all_columns_join_colsand its parameterization. - Leaves production behavior unchanged.
| File | Description |
|---|---|
tests/summary/test_summary.py |
Removes the test for summaries with only primary-key columns. |
Review effort: Balanced
Marius Merkle (MariusMerkleQC)
marked this pull request as ready for review
October 26, 2026 09:05
Marius Merkle (MariusMerkleQC)
requested review from
EgeKaraismailogluQC and
Oliver Borchert (borchero)
as code owners
October 26, 2026 09:05
EgeKaraismailogluQC
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Similar spirit to this comment. The behavior of the test is already covered by the fixture
no_common_non_pk_columns.Changes
test_summary_all_columns_join_cols