Skip to content

Enzyme forward rule for truncate and tests - #288

Merged
lkdvos merged 4 commits into
mainfrom
ksh/trunc_fwd
Oct 3, 2026
Merged

lkdvos merged 4 commits into
mainfrom
ksh/trunc_fwd

Conversation

@kshyatt

@kshyatt kshyatt commented Oct 1, 2026

Copy link
Copy Markdown
Member

No description provided.

@kshyatt
kshyatt requested a review from lkdvos October 1, 2026 09:23
@kshyatt kshyatt changed the title Forward rule for truncate and tests Enzyme forward rule for truncate and tests Oct 1, 2026
@kshyatt

kshyatt commented Oct 1, 2026

Copy link
Copy Markdown
Member Author

Failures here will be fixed by #290

@kshyatt
kshyatt changed the base branch from main to ksh/eig_fwd October 1, 2026 10:08
@kshyatt
kshyatt added this pull request to stack #291 October 1, 2026 10:14
@kshyatt
kshyatt removed this pull request from stack #291 October 1, 2026 12:40
Base automatically changed from ksh/eig_fwd to main October 1, 2026 13:17
@codecov

codecov Bot commented Oct 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 64.51613% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ixAlgebraKitEnzymeExt/MatrixAlgebraKitEnzymeExt.jl 64.51% 11 Missing ⚠️
Files with missing lines Coverage Δ
...ixAlgebraKitEnzymeExt/MatrixAlgebraKitEnzymeExt.jl 78.74% <64.51%> (+78.74%) ⬆️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos lkdvos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, some minor suggestions but otherwise good to merge from my end

Comment thread ext/MatrixAlgebraKitEnzymeExt/MatrixAlgebraKitEnzymeExt.jl Outdated
Comment thread ext/MatrixAlgebraKitEnzymeExt/MatrixAlgebraKitEnzymeExt.jl Outdated
Comment thread test/testsuite/enzyme/eigh.jl
Comment thread test/testsuite/enzyme/svd.jl
@kshyatt
kshyatt enabled auto-merge (squash) October 2, 2026 15:08
@lkdvos
lkdvos merged commit af6a263 into main Oct 3, 2026
46 of 47 checks passed
@lkdvos
lkdvos deleted the ksh/trunc_fwd branch October 3, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants