Conversation
lkdvos
reviewed
Oct 1, 2026
| finite-difference checks. | ||
| """ | ||
| function midgap_tol(vals) | ||
| s = sort!(collect(abs.(vals))) |
Member
There was a problem hiding this comment.
why do we need the collect, shouldn't abs already give a vector?
Suggested change
| s = sort!(collect(abs.(vals))) | |
| s = sort!(abs.(vals)) |
Member
Author
There was a problem hiding this comment.
Not if vals lives on the GPU, right?
Member
There was a problem hiding this comment.
ah, I missed the GPU case :) doesn't sort! also work on the GPU though?
Member
Author
There was a problem hiding this comment.
yeah it does but I was skittish of the logic later on so I just did everything on CPU instead 😭
lkdvos
approved these changes
Oct 1, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple test nits here:
trunctols that were also not playing nicely with FDHopefully this gets Mooncake and buddies consistently back on the path of happiness.