Conversation
Member
Author
|
Oh crap lol I was working on top of a |
Codecov Report❌ Patch coverage is
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
kshyatt
marked this pull request as draft
June 26, 2026 14:10
Member
Author
|
Weirdly the eig failures seem to go away on |
Contributor
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
kshyatt
force-pushed
the
ksh/enz_fact
branch
4 times, most recently
from
July 6, 2026 18:14
e0a9f0c to
9742ab7
Compare
kshyatt
force-pushed
the
ksh/enz_fact
branch
3 times, most recently
from
July 15, 2026 14:21
049c1a0 to
a60a6ca
Compare
Member
Author
|
This |
kshyatt
force-pushed
the
ksh/enz_fact
branch
3 times, most recently
from
August 5, 2026 09:50
215e3f0 to
78d8a98
Compare
kshyatt
force-pushed
the
ksh/enz_fact
branch
2 times, most recently
from
August 5, 2026 22:06
a938fca to
17e422c
Compare
kshyatt
marked this pull request as ready for review
August 6, 2026 07:58
kshyatt
force-pushed
the
ksh/enz_fact
branch
from
September 14, 2026 12:46
17e422c to
c4d0f3d
Compare
kshyatt
force-pushed
the
ksh/enz_fact
branch
from
September 24, 2026 09:11
e72c78c to
47a62e8
Compare
lkdvos
reviewed
Sep 30, 2026
kshyatt
marked this pull request as draft
September 30, 2026 18:26
Member
Author
|
Gonna make this a draft since 1.10 is going to fail anyway and the forward mode stuff needs some love |
kshyatt
force-pushed
the
ksh/enz_fact
branch
from
September 30, 2026 18:39
6131934 to
6a911a7
Compare
Member
Author
|
Tests passing 😸 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason
svd_compactandsvd_trunc_no_errordon't play nicely with Enzyme here using the MAK rules, I think because of theDiagonalTensorMapoutput. I can try to investigate further if preferred. I also added some additional logic in pullbacks to match what the MAK pullbacks actually kick back.