Skip to content

fix(marketplace): release builds ship the mock catalog and mock installs write to the real extensions folder #1568

Open

Description

@ZhuchkaTriplesix

Problem

MarketplaceRepository.instance defaults to MockMarketplaceRepository() (lib/core/market/marketplace_repository.dart:27), and HttpMarketplaceRepository is constructed nowhere in lib/ (only in tests). So the release app's Extension Manager shows and installs a hard-coded demo catalog:

  • 6 fake listings (ClickHouse / Redis / MongoDB / "postgres-exporter" drivers, two themes), some tagged official, with cdn.queryahub.com URLs and fake checksums (e3b0c442...b855 is the SHA-256 of an empty string). Nothing in the UI says the catalog is a demo; the only badge is "Preview" for drivers.
  • Search and "download" are Future.delayed loops that fake progress.
  • Install writes to the user's real extensions folder (ExtensionPaths.extensionsDirectory()): a manifest-only directory, and for themes a generated theme.json. These persist across updates and show as installed extensions.
  • Bug in the generated theme (:278): the template is a non-raw '''...''' string containing "\${manifest.name}". \$ escapes the interpolation, so every generic mock theme is literally named ${manifest.name}.

CHANGELOG lists "Planned 0.5.0 — live Marketplace download and install", so the mock is intentional, but it should not reach users this way.

Fix

Activity

  1. added
    bugSomething isn't working
    marketplaceExtensions marketplace, ExtensionManifest
    uxUser experience, keyboard shortcuts and interactions
    P2Medium priority / Parity & Refactoring
    on Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Medium priority / Parity & RefactoringbugSomething isn't workingmarketplaceExtensions marketplace, ExtensionManifestuxUser experience, keyboard shortcuts and interactions

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions