Repository navigation
refactor(ui): name dialogs use QueryaDialogActions for their footer - #1462
Merged
Merged
Conversation
ERD group / note / view name, New folder and Create database build a Cancel + primary footer by hand (12 px gap, own divider). They now use QueryaDialogActions: order, spacing 8, lg, one divider, Esc cancels. Refs #1441
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1441.
Five small dialogs built the same Cancel + primary footer by hand (own container and divider, 12 px between the buttons): ERD group, note and view name, New folder, and Create database (Mongo). They now use
QueryaDialogActions, wrapped in theListenableBuilderthat enables the primary action while the name is valid. Spacing becomes the standard 8 px, the divider comes from the kit and Esc cancels.Mechanical change, found by a script that only rewrites the exact pattern (ghost Cancel, a gap, a
ListenableBuilderwith a primary button); the other footers (forms with Test connection, destructive confirmations) are for follow-up PRs under #1441.